-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libsinsp): expose main thread fd table #2133
base: master
Are you sure you want to change the base?
Conversation
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
========================================
Coverage 74.46% 74.46%
========================================
Files 253 254 +1
Lines 33069 33340 +271
Branches 5697 5727 +30
========================================
+ Hits 24624 24827 +203
- Misses 8445 8507 +62
- Partials 0 6 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gianmatteo Palmieri <[email protected]>
2fec49f
to
2cd6315
Compare
@@ -1385,6 +1393,8 @@ void sinsp_thread_manager::create_thread_dependencies( | |||
return; | |||
} | |||
parent_thread->add_child(tinfo); | |||
|
|||
tinfo->update_main_fdtable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putting this in create_thread_dependencies
should correctly set the fdtable in all cases
- /proc scan at initi time
- /proc scan at runtime
- when a new thread is added after a clone syscall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: bc6dcb27c550d8a5c39f8548bf0ee496a702cb78
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR ensures that the plugin API exposes the file descriptor table of its main thread instead of its own.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: