Prevent inttypes.h from being wrapped in namespace #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
By wrapping C includes in a namespace declaration, we make it so that any libc headers will also belong to the resulting C namespace. In the case of
inttypes.h
, this creates problems in the user's code when depending on declarations likeimaxdiv_t
to be in the global namespace and notfalcosecurity::_internal
. This problem is also compounded when combining the SDK with libraries with their own header files.This PR simply adds a line to
deps.h
to ensure thatinttypes.h
is included before a namespace is opened.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: