-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: update SDK to plugin API version 3.6.0 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor points to be solved before merging
Tagging myself here to know when this gets merged. |
Signed-off-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]>
I solved these points but please don't merge this for now. I've tried running this example for a while https://github.com/mrgian/plugin-sdk-cpp/blob/update-3.6.0-new/examples/syscall_parse/plugin.cpp |
Signed-off-by: Gianmatteo Palmieri <[email protected]> Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]>
After investigating the issue with @jasondellaluce, looks like the the issue is on the libs side. @incertum I also added a new example showing how to access the @jasondellaluce the example has a lot of prints, should we keep it as is or should we remove them before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 4e71d0d6997a520e57ebf14865b3b6a5bed3249b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: