Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release table_entry with the move operator and add default constructor for table_entry #39

Merged

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

The table_entry class was missing the default constructor.
The table_entry move operator didn't clean up the left hand side table_entry when moving

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Roberto Scolaro <[email protected]>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes labels Aug 6, 2024
@poiana
Copy link

poiana commented Aug 6, 2024

@therealbobo: The label(s) kind/design cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

The table_entry class was missing the default constructor.
The table_entry move operator didn't clean up the left hand side table_entry when moving

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana requested review from leogr and mstemm August 6, 2024 14:27
@poiana poiana added the size/S label Aug 6, 2024
@therealbobo therealbobo force-pushed the therealbobo-fix-table-entry-release branch from f9cb7fb to 8a5f87d Compare August 6, 2024 14:56
Signed-off-by: Roberto Scolaro <[email protected]>
@poiana
Copy link

poiana commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstemm, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Aug 6, 2024

LGTM label has been added.

Git tree hash: 5e974c99c30e68c93fee1bf92ae6b10390768deb

@poiana poiana added the approved label Aug 6, 2024
@poiana poiana merged commit ffba940 into falcosecurity:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants