Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudtrail s3 interval #275

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Cloudtrail s3 interval #275

merged 5 commits into from
Jul 17, 2023

Commits on Jul 13, 2023

  1. update(plugins/cloudtrail): Add dependencies to our Makefile 

    Signed-off-by: Gerald Combs <[email protected]>
    @geraldcombs
    geraldcombs committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    69327a8 View commit details
    Browse the repository at this point in the history

  2. update(plugins/cloudtrail): Add an S3Interval option 

    Add an "S3Interval" option, which limits log downloads to the specified
time interval. Intervals can be a simple "relative time in the past to
now", "an absolute timestamp until now", or a range of those two
formats.

The interval is applied at the far end using the StartAfter parameter
and locally to filter log pathnames. In my informal testing here the
time from capture start to first event is ~2s.

Signed-off-by: Gerald Combs <[email protected]>
    @geraldcombs
    geraldcombs committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    88fcf49 View commit details
    Browse the repository at this point in the history

  3. update(plugins/cloudtrail): Fix a time comparison 

    Time.Compare was added in go 1.20.

Signed-off-by: Gerald Combs <[email protected]>
    @geraldcombs
    geraldcombs committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    02d7fa3 View commit details
    Browse the repository at this point in the history

  4. update(plugins/cloudtrail): Remove a dependency 

    Remove our dependency on str2duration. Fix our interval regex.

Signed-off-by: Gerald Combs <[email protected]>
    @geraldcombs
    geraldcombs committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    07d11f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. update(plugins/cloudtrail): Make our default interval "" 

    Make our default interval "" (which fetches all logs) instead of "24h".

Signed-off-by: Gerald Combs <[email protected]>
    @geraldcombs
    geraldcombs committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0da7894 View commit details
    Browse the repository at this point in the history