Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: contributing GCP plugin #311

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Conversation

ahmedameenaim
Copy link
Contributor

@ahmedameenaim ahmedameenaim commented Jul 17, 2023

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: ahmedameenaim <[email protected]>
@jasondellaluce
Copy link
Contributor

Thanks @ahmedameenaim, I will help you adapt this branch to solve the issues with our CI.

Since you're the original author of this, would you like to become a maintainer of the subdirectory containing this plugin? This would make you an approver of all the changes involving the GCP plugins, and you'll join the falcosecurity org.

Please let me know, so that I can provide help setting up an OWNERS file.

cc @falcosecurity/plugins-maintainers

@ahmedameenaim
Copy link
Contributor Author

ahmedameenaim commented Jul 19, 2023

@jasondellaluce Yeah, I want to become a maintainer for the plugin. I'm committed to all his duties.

Signed-off-by: Jason Dellaluce <[email protected]>
@github-actions
Copy link

Rules files suggestions

@leogr
Copy link
Member

leogr commented Jul 19, 2023

big +1 from me 😍

@jasondellaluce jasondellaluce changed the title Contributing GCP plugin vote: contributing GCP plugin Jul 19, 2023
@jasondellaluce
Copy link
Contributor

+1 from me for your maintainership on the plugin you authored!

@github-actions
Copy link

Rules files suggestions

@jasondellaluce
Copy link
Contributor

Considering me and Leo, we already have an agreement on having you as a maintainer of the plugin's subdir.

Adding you as a member of the org, so that this PR can be unblocked: falcosecurity/test-infra#1197

@jasondellaluce
Copy link
Contributor

/verify-owners

1 similar comment
@jasondellaluce
Copy link
Contributor

/verify-owners

@poiana
Copy link
Contributor

poiana commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedameenaim, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jul 20, 2023

LGTM label has been added.

Git tree hash: 440de61f213ff5cb44f32683424f7b4dc44b146b

@poiana poiana merged commit 9e06fd7 into falcosecurity:master Jul 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants