-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: contributing GCP plugin #311
Conversation
Signed-off-by: ahmedameenaim <[email protected]>
Thanks @ahmedameenaim, I will help you adapt this branch to solve the issues with our CI. Since you're the original author of this, would you like to become a maintainer of the subdirectory containing this plugin? This would make you an approver of all the changes involving the GCP plugins, and you'll join the falcosecurity org. Please let me know, so that I can provide help setting up an OWNERS file. cc @falcosecurity/plugins-maintainers |
@jasondellaluce Yeah, I want to become a maintainer for the plugin. I'm committed to all his duties. |
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Rules files suggestions |
big +1 from me 😍 |
+1 from me for your maintainership on the plugin you authored! |
Signed-off-by: Jason Dellaluce <[email protected]>
Rules files suggestions |
Considering me and Leo, we already have an agreement on having you as a maintainer of the plugin's subdir. Adding you as a member of the org, so that this PR can be unblocked: falcosecurity/test-infra#1197 |
/verify-owners |
1 similar comment
/verify-owners |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedameenaim, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 440de61f213ff5cb44f32683424f7b4dc44b146b
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: