-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add artifact signature information to the generated index #312
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
182949a
disable release.yml trigger
maxgio92 4133b59
feat(pkg/registry): add index entry signature to registry model
maxgio92 428bdc7
feat(pkg/distribution): generate index with signature from registry m…
maxgio92 6202398
test(pkg/distribution): add initial index-update black box unit tests
maxgio92 5ab0463
test(pkg/distribution): add initial index entry signature unit test
maxgio92 a3d9150
deps: bump falcoctl to v0.6.1
maxgio92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
build/registry/pkg/distribution/distribution_suite_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
Copyright (C) 2022 The Falco Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package distribution_test | ||
|
||
import ( | ||
"testing" | ||
|
||
. "github.com/onsi/ginkgo/v2" | ||
. "github.com/onsi/gomega" | ||
) | ||
|
||
func TestDistribution(t *testing.T) { | ||
RegisterFailHandler(Fail) | ||
RunSpecs(t, "Distribution Suite") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
Copyright (C) 2022 The Falco Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package distribution_test | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
|
||
"github.com/falcosecurity/falcoctl/pkg/index/index" | ||
|
||
"github.com/falcosecurity/plugins/build/registry/pkg/distribution" | ||
"github.com/falcosecurity/plugins/build/registry/pkg/registry" | ||
) | ||
|
||
func TestPluginToIndexEntrySignature(t *testing.T) { | ||
t.Parallel() | ||
|
||
signature := &index.Signature{ | ||
Cosign: &index.CosignSignature{}, | ||
} | ||
|
||
expected := signature | ||
|
||
p := registry.Plugin{Signature: signature} | ||
|
||
entry := distribution.PluginToIndexEntry(p, "", "") | ||
if !reflect.DeepEqual(entry.Signature, expected) { | ||
t.Fatalf("Index entry signature: expected %#v, got %v", expected, entry.Signature) | ||
} | ||
} | ||
|
||
func TestPluginRulesToIndexEntrySignature(t *testing.T) { | ||
t.Parallel() | ||
|
||
signature := &index.Signature{ | ||
Cosign: &index.CosignSignature{}, | ||
} | ||
|
||
expected := signature | ||
|
||
p := registry.Plugin{Signature: signature} | ||
|
||
entry := distribution.PluginRulesToIndexEntry(p, "", "") | ||
if !reflect.DeepEqual(entry.Signature, expected) { | ||
t.Fatalf("Index entry signature: expected %#v, got %v", expected, entry.Signature) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/* | ||
Copyright (C) 2022 The Falco Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package distribution_test | ||
|
||
import ( | ||
"os" | ||
|
||
. "github.com/onsi/ginkgo/v2" | ||
. "github.com/onsi/gomega" | ||
|
||
"github.com/falcosecurity/plugins/build/registry/pkg/distribution" | ||
) | ||
|
||
const ( | ||
indexFile = "testdata/index.yaml" | ||
wrongIndexFile = "testdata/wrong-index.yaml" | ||
registryFile = "testdata/registry.yaml" | ||
wrongRegistryFile = "testdata/wrong-registry.yaml" | ||
registryUser = "falcosecurity" | ||
registryName = "ghcr.io" | ||
) | ||
|
||
var _ = Describe("Update index", func() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These black box unit test provide the minimum expected behaviour with specifications of the index update from the registry manifest. It should be then extended. |
||
var ( | ||
err error | ||
) | ||
Context("with registry file", func() { | ||
BeforeEach(func() { | ||
os.Setenv("REGISTRY_USER", registryUser) | ||
os.Setenv("REGISTRY", registryName) | ||
}) | ||
Context("with index file", func() { | ||
BeforeEach(func() { | ||
err = distribution.DoUpdateIndex(registryFile, indexFile) | ||
}) | ||
It("Should not fail", func() { | ||
Expect(err).To(BeNil()) | ||
}) | ||
}) | ||
Context("without index file", func() { | ||
BeforeEach(func() { | ||
err = distribution.DoUpdateIndex(registryFile, wrongIndexFile) | ||
}) | ||
It("Should fail", func() { | ||
Expect(err).ToNot(BeNil()) | ||
}) | ||
}) | ||
}) | ||
Context("without registry file", func() { | ||
BeforeEach(func() { | ||
os.Setenv("REGISTRY_USER", registryUser) | ||
os.Setenv("REGISTRY", registryName) | ||
}) | ||
Context("with index file", func() { | ||
BeforeEach(func() { | ||
err = distribution.DoUpdateIndex(wrongRegistryFile, indexFile) | ||
}) | ||
It("Should fail", func() { | ||
Expect(err).ToNot(BeNil()) | ||
}) | ||
}) | ||
Context("without index file", func() { | ||
BeforeEach(func() { | ||
err = distribution.DoUpdateIndex(wrongRegistryFile, wrongIndexFile) | ||
}) | ||
It("Should fail", func() { | ||
Expect(err).ToNot(BeNil()) | ||
}) | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These unit tests assert the minimum expectations from this feature.