-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: add Issif as approvers for k8saudit-eks plugin #320
Conversation
2d27dc5
to
737be13
Compare
@leogr @mstemm @jasondellaluce Do you vote for? |
Rules files suggestions |
737be13
to
4d53321
Compare
Signed-off-by: Thomas Labarussias <[email protected]>
4d53321
to
9d4ff63
Compare
Rules files suggestions |
Ofc, +1 for me 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! 🥳 (since we have a majority and no further votes cannot change the outcome)
LGTM label has been added. Git tree hash: abac7b95c685272edfb966a250a0ae17c5f0b9c2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
I'm proposing myself as approver of the
k8saudit-eks
plugin, as I developed it, it seems logical to be able to review proposals from the community.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: