Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): avoid using gocheck=2 #325

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix(plugins): avoid using gocheck=2 #325

merged 2 commits into from
Aug 29, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

Supposedly fixes the following error from CodeQL C++:

fatal error: cgocheck > 1 mode is no longer supported at runtime. Use GOEXPERIMENT=cgocheck2 at build time instead.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

LGTM label has been added.

Git tree hash: 99ca59089915d492955f93871e987ab268acfb94

@poiana poiana merged commit c7bc1e9 into master Aug 29, 2023
23 of 26 checks passed
@poiana poiana deleted the fix/gocheck-codeql branch August 29, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants