Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: add sboschman as approver for k8saudit-gke, and add the plugin to the registry #437

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

sboschman
Copy link
Contributor

@Issif or @leogr , as we handed out plugin id 16 for k8saudit-gke, it might be useful to list it in the plugins readme

@Issif
Copy link
Member

Issif commented Mar 14, 2024

The list of plugins is auto-generated from the registry.yaml. See the other entries as examples and update it, then run make update-readme.

BTW, as the original author of the plugin, I would recommend you to create an OWNER file at the root of the plugin, like this one https://github.com/falcosecurity/plugins/blob/master/plugins/k8saudit-eks/OWNERS, it will allow you to review/approve futures PR.

cc @leogr @jasondellaluce @mstemm

Copy link

Rules files suggestions

Comment on lines +1 to +2
approvers:
- sboschman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our governance adding a maintainer requires a majority vote

Eligible voters are @falcosecurity/plugins-maintainers

So

/hold until we get the majority or a week has passed

Ofc, +1 from me 👍

@leogr leogr changed the title docs: add k8saudit-gke to plugin list vote: add sboschman as approver for k8saudit-gke, and add the plugin to the registry Mar 15, 2024
@poiana
Copy link
Contributor

poiana commented Mar 22, 2024

LGTM label has been added.

Git tree hash: e3f8f18508af6906760d23338ec5d26b4448923c

@leogr
Copy link
Member

leogr commented Mar 25, 2024

We got the majority and also week has passed, so
/unhold

Welcome on board @sboschman 👏

We will take care of the procedure to set up your account as a maintainer.
cc @FedeDP @LucaGuerra

@sboschman meanwhile, could I just ask you to add yourself to this file?

@leogr
Copy link
Member

leogr commented Mar 25, 2024

N.B. @sboschman you get an GitHub invitation to the falcosecurity organization once this PR gets merged.

@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, sboschman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Mar 25, 2024

/verify-owners

@poiana poiana merged commit 3d7ce9e into falcosecurity:master Mar 25, 2024
12 checks passed
@sboschman sboschman deleted the patch-1 branch March 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants