Move Terraform CI/CD to GitHub Actions #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
maxgio92
changed the title
maxgio92
changed the title
maxgio92
commented
Aug 11, 2023
|
Is this different from #961 ? |
|
I'm sorry I didnt' consider #961. Anyway it cleans up the wrapper bash scripts and it uses Terraform gihub actions directly. Furthermore, it executes the Terraform plan during PR submission in order to be able to verify the expected plan apply, before merging it. Anyway, this PR needs rebase on top of #961 |
|
Wow makes sense! Thank you Max! |
|
@maxgio92: The following tests failed, say
Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
@maxgio92 CI is now ported to github actions; this PR looks very good and a needed refactor; are you willing to rebase it on top of master? Thanks! |
|
Sure @FedeDP |
FedeDP
reviewed
Feb 21, 2024
FedeDP
reviewed
Feb 21, 2024
maxgio92
changed the title
|
/hold |
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
issue/1211
branch
2 times, most recently
from
f6f63c4
to
16f4a4e
Compare
Terraform Format and Style 🖌
|
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
commented
Mar 21, 2024
| { | ||
| rolearn = "arn:aws:iam::292999226676:role/github_actions-test-infra-reader" | ||
| username = "githubactions-test-infra-reader" | ||
| groups = ["aws-config-readers"] |
There was a problem hiding this comment.
This is a mapping of the AWS role mentioned to a custom Kubernetes group aws-config-readers.
More detail on the expected permissions in Kubernetes to be bound to that group there: #1426
FedeDP
reviewed
Mar 22, 2024
| @@ -24,10 +24,6 @@ jobs: | |||
| role-to-assume: "arn:aws:iam::292999226676:role/github_actions-test-infra-cluster" | |||
| aws-region: eu-west-1 | |||
|
|
|||
| - name: Deploy terraform | |||
There was a problem hiding this comment.
Also, we can cleanup the script, right?
Moreover, i'd rename this CI to Master CI - deploy prow and the new one to Master CI - apply terraform (or something similar :D )
There was a problem hiding this comment.
Totally agree @FedeDP. Implemented, PTAL
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the CICD pipeline of the cloud infrastructure managed with Terraform, from CircleCI to GitHub.
Fixes #1211