new(driverkit/config): add build config for 6.1.0-rpi7-rpi-2712_1 #1323

Nabsku · 2023-12-15T14:40:07Z

No description provided.

poiana · 2023-12-15T14:40:17Z

Welcome @Nabsku! It looks like this is your first PR to falcosecurity/test-infra 🎉

poiana · 2023-12-15T14:40:18Z

Hi @Nabsku. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana · 2023-12-15T14:40:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nabsku
Once this PR has been reviewed and has the lgtm label, please assign maxgio92 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Nabsku <[email protected]>

FedeDP · 2023-12-15T14:43:56Z

/ok-to-test

FedeDP · 2023-12-15T14:51:28Z

Hi! Thanks for opening this PR!
Can you share uname -a on your debian rpi machine?

Nabsku · 2023-12-15T14:52:42Z

Of course!

It's a RaspiOS Debian running on a Pi5.

Linux node5 6.1.0-rpi7-rpi-2712 #1 SMP PREEMPT Debian 1:6.1.63-1+rpt1 (2023-11-24) aarch64 GNU/Linux

FedeDP · 2023-12-15T15:11:06Z

Thanks! I am trying to understand why we are not catching any rpi kernel in kernel-crawler: falcosecurity/kernel-crawler#192

We can try merging this one but i fear that without specifying kernelurls, driverkit won't be able to build any driver.

EDIT: unfortunately my PR on kernel-crawler is not enough :/ falcosecurity/kernel-crawler#192 (comment)

Nabsku · 2023-12-15T15:35:40Z

Am not the most proficient kernel guru but I can try and find these kernelurls, if that helps?

But it seems we've uncovered a bug in the crawler then?

FedeDP · 2023-12-15T15:38:17Z

But it seems we've uncovered a bug in the crawler then?

Exactly :)

Am not the most proficient kernel guru but I can try and find these kernelurls, if that helps?

Yes that would be great! If you check other debian configs in the same folders, you'll see how the kernelurls are added!

Signed-off-by: Nabsku <[email protected]>

Nabsku · 2023-12-15T15:54:28Z

I believe/hope this is correct.

Now that I think of it, does the crawler look for kernels in the Raspberry repos?

driverkit/config/4.0.0+driver/aarch64/debian_6.1.0-rpi7-rpi-2712_1.yaml

FedeDP · 2023-12-15T15:58:43Z

Now that I think of it, does the crawler look for kernels in the Raspberry repos?

I don't think so, that's the problem :D

EDIT: i am trying locally to add http://archive.raspberrypi.com/debian to the list of repositories to be crawled.

Signed-off-by: Nabsku <[email protected]>

FedeDP · 2023-12-15T16:35:49Z

Yay:

Building dependency tree  [####################################]  100%
{
  "debian": [
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.21-1+rpt1-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi1-rpi-v8_6.1.21-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi1-common-rpi_6.1.21-1+rpt1_all.deb"
      ]
    },
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.47-1+rpt2-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi2-common-rpi_6.1.47-1+rpt2_all.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi2-rpi-v8_6.1.47-1+rpt2_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb"
      ]
    },
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.47-1+rpt4-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi3-common-rpi_6.1.47-1+rpt4_all.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi3-rpi-2712_6.1.47-1+rpt4_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi3-rpi-v8_6.1.47-1+rpt4_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb"
      ]
    },
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.54-1+rpt2-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi4-rpi-v8_6.1.54-1+rpt2_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi4-rpi-2712_6.1.54-1+rpt2_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi4-common-rpi_6.1.54-1+rpt2_all.deb"
      ]
    },
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.58-1+rpt2-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi6-rpi-2712_6.1.58-1+rpt2_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi6-rpi-v8_6.1.58-1+rpt2_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi6-common-rpi_6.1.58-1+rpt2_all.deb"
      ]
    },
    {
      "kernelversion": "1",
      "kernelrelease": "1:6.1.63-1+rpt1-rpi-arm64",
      "target": "debian",
      "headers": [
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi7-rpi-v8_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-kbuild-6.1_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi7-rpi-2712_6.1.63-1+rpt1_arm64.deb",
        "http://archive.raspberrypi.com/debian/pool/main/l/linux/linux-headers-6.1.0-rpi7-common-rpi_6.1.63-1+rpt1_all.deb"
      ]
    }
  ]
}

Nabsku · 2023-12-15T16:38:02Z

Awesome!

FedeDP · 2023-12-15T16:41:37Z

If we are quick enough to merge the PR, i would let the next kernel-crawler pipeline run (tomorrow morning) create the new driverkit configs for us! Wdyt?

Nabsku · 2023-12-15T16:44:17Z

I'm all for it :) Is there anything left to do? If so just say the word!

FedeDP · 2023-12-15T16:46:25Z

I'm all for it :) Is there anything left to do? If so just say the word!

Nothing, as soon as my kenrel-crawler patch gets merged, i will tag a new release and tomorrow morning you will find Falco drivers built and published on download.falco.org!

Nabsku · 2023-12-15T16:50:20Z

Shall I close this PR? Probably not needed anymore, right? :) Thanks for your help!

FedeDP · 2023-12-15T17:02:33Z

I think so! You are welcome, thanks for spotting the issue!

FedeDP · 2023-12-15T17:07:23Z

Tag created: https://github.com/falcosecurity/kernel-crawler/releases/tag/0.14.0

FedeDP · 2023-12-16T09:14:15Z

Oh I didn't notice the "1:" prefix in the output kernel release:

1:6.1.63-1+rpt1-rpi-arm64

Will need to fix this on Monday; sorry!

FedeDP · 2023-12-18T09:41:02Z

Ok fixed, and currently re running kernel-crawler: https://github.com/falcosecurity/kernel-crawler/actions/runs/7246238172.
Expect drivers to come alive in ~1h!

FedeDP · 2023-12-19T08:49:10Z

Unfortunately, it seems driverkit is not able to build the drivers for rpi debian kernels.
Here is the fix: falcosecurity/driverkit#314

FedeDP · 2023-12-20T15:09:01Z

We finally have prebuilt drivers for rpi debian kernels 😄
Thanks for your patience @Nabsku

poiana added the dco-signoff: no label Dec 15, 2023

poiana added the needs-ok-to-test label Dec 15, 2023

poiana added the size/S label Dec 15, 2023

poiana requested review from FedeDP and zuc December 15, 2023 14:40

added raspi5 raspios support

58b7e08

Signed-off-by: Nabsku <[email protected]>

Nabsku force-pushed the new/driver-build-config branch from 45637a0 to 58b7e08 Compare December 15, 2023 14:41

poiana added dco-signoff: yes and removed dco-signoff: no labels Dec 15, 2023

poiana added ok-to-test and removed needs-ok-to-test labels Dec 15, 2023

Added kernelurls for raspi kernel

1a3e9d8

Signed-off-by: Nabsku <[email protected]>

FedeDP reviewed Dec 15, 2023

View reviewed changes

driverkit/config/4.0.0+driver/aarch64/debian_6.1.0-rpi7-rpi-2712_1.yaml Outdated Show resolved Hide resolved

Added correct kernelurls this time

fe70911

Signed-off-by: Nabsku <[email protected]>

poiana added size/M and removed size/S labels Dec 15, 2023

Nabsku closed this Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new(driverkit/config): add build config for 6.1.0-rpi7-rpi-2712_1 #1323

new(driverkit/config): add build config for 6.1.0-rpi7-rpi-2712_1 #1323

Nabsku commented Dec 15, 2023

poiana commented Dec 15, 2023

poiana commented Dec 15, 2023

poiana commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023 •

edited

Loading

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023 •

edited

Loading

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023 •

edited

Loading

FedeDP commented Dec 15, 2023 •

edited

Loading

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 16, 2023

FedeDP commented Dec 18, 2023

FedeDP commented Dec 19, 2023

FedeDP commented Dec 20, 2023

new(driverkit/config): add build config for 6.1.0-rpi7-rpi-2712_1 #1323

new(driverkit/config): add build config for 6.1.0-rpi7-rpi-2712_1 #1323

Conversation

Nabsku commented Dec 15, 2023

poiana commented Dec 15, 2023

poiana commented Dec 15, 2023

poiana commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023 • edited Loading

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023 • edited Loading

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

Nabsku commented Dec 15, 2023 • edited Loading

FedeDP commented Dec 15, 2023 • edited Loading

Nabsku commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 15, 2023

FedeDP commented Dec 16, 2023

FedeDP commented Dec 18, 2023

FedeDP commented Dec 19, 2023

FedeDP commented Dec 20, 2023

FedeDP commented Dec 15, 2023 •

edited

Loading

FedeDP commented Dec 15, 2023 •

edited

Loading

Nabsku commented Dec 15, 2023 •

edited

Loading

FedeDP commented Dec 15, 2023 •

edited

Loading