Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(ci,tools): added a small prow jobs checker and validator plus a CI job #1460

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 16, 2024

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply leverages k8s.io prow go package to check that every jobs config can be actually parsed to a GO prow job, and validates it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super useful, will reduce lot of work and PRs 🤣

@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 16, 2024

The job triggered correctly, and failed because branchprotector needed some changes: https://github.com/falcosecurity/test-infra/actions/runs/8705912420/job/23877328866?pr=1460

ERR Failed to parse configuration err="error unmarshaling config/jobs/branchprotector/branchprotector.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "skip_report""

@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 16, 2024

/cc @maxgio92

Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous @FedeDP

/approve

@poiana
Copy link
Contributor

poiana commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 079a776 into master Apr 16, 2024
7 checks passed
@poiana poiana deleted the new/jobs-checker branch April 16, 2024 12:58
@poiana
Copy link
Contributor

poiana commented Apr 16, 2024

@FedeDP: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key branchprotector.yaml using file config/jobs/branchprotector/branchprotector.yaml
  • key peribolos.yaml using file config/jobs/peribolos/peribolos.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants