new(ci): added gha. #961

FedeDP · 2023-01-20T08:01:27Z

No description provided.

FedeDP · 2023-01-20T08:02:44Z

Pre submit job is ok. Here the hard part is fixing up post submit jobs.

LucaGuerra · 2023-01-20T09:32:30Z

It looks like this job doesn't have permissions to do the actual deploy.
Right now I'm fixing tf to allow the GitHub OIDC provider to work. After that is done, we probably want to properly authorize GHA there so this job will just work(TM)

maxgio92 · 2023-01-20T09:50:50Z

Thanks @FedeDP, just a note to keep in mind. It would optimal if the Terraform job would use the version specified in the code (something like this rude trick)

LucaGuerra · 2023-01-20T09:52:22Z

@maxgio92 I believe deploy_terraform.sh already does this

poiana · 2023-04-20T13:27:40Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

FedeDP · 2023-04-20T13:29:18Z

/remove-lifecycle stale

FedeDP · 2023-05-17T13:23:22Z

Note this also needs #1159.

FedeDP · 2023-05-17T13:33:12Z

I'll remove the wip and put this on hold since it is reviewable now, but still needs #1159 first.

FedeDP · 2023-05-17T13:33:20Z

/hold

leogr · 2023-05-18T15:47:24Z

Nice 🤔

FedeDP · 2023-05-18T15:57:31Z

Yep it's because i deleted the whole workflow for circleci; it's not important.

leogr · 2023-05-18T16:26:09Z

Yep it's because i deleted the whole workflow for circleci; it's not important.

But, it's still nice 🤣

poiana · 2023-08-16T19:32:57Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana · 2024-02-19T15:49:05Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

FedeDP · 2024-02-19T15:50:19Z

/remove-lifecycle stale

Signed-off-by: Federico Di Pierro <[email protected]>

Renamed postsubmit to master. Fixes to PR ci. Signed-off-by: Federico Di Pierro <[email protected]>

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP · 2024-02-20T09:55:48Z

/unhold

FedeDP · 2024-02-20T09:56:20Z

/hold

leogr

/approve

poiana · 2024-02-20T09:57:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [FedeDP,leogr,maxgio92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2024-02-20T10:23:11Z

/unhold

poiana added the dco-signoff: yes label Jan 20, 2023

FedeDP changed the title ~~new(ci): added gha.~~ wip: new(ci): added gha. Jan 20, 2023

poiana added do-not-merge/work-in-progress size/M labels Jan 20, 2023

poiana requested review from jonahjon and leogr January 20, 2023 08:04

poiana added the approved label Jan 20, 2023

poiana added the lifecycle/stale label Apr 20, 2023

poiana removed the lifecycle/stale label Apr 20, 2023

FedeDP force-pushed the new/gha branch from 66d5bd9 to 0a9cb9c Compare May 17, 2023 12:47

poiana added size/L and removed size/M labels May 17, 2023

FedeDP force-pushed the new/gha branch from cc2a1aa to 251882b Compare May 17, 2023 13:22

FedeDP force-pushed the new/gha branch from eccbe3d to ac8e807 Compare May 17, 2023 13:30

poiana added the do-not-merge/hold label May 17, 2023

FedeDP changed the title ~~wip: new(ci): added gha.~~ new(ci): added gha. May 17, 2023

poiana removed the do-not-merge/work-in-progress label May 17, 2023

poiana removed the lifecycle/stale label Nov 21, 2023

poiana added the lifecycle/stale label Feb 19, 2024

poiana removed the lifecycle/stale label Feb 19, 2024

FedeDP added 4 commits February 20, 2024 09:56

new(ci): added gha.

34238ce

Signed-off-by: Federico Di Pierro <[email protected]>

chore(ci): merged presubmit and validate_manifests into a single ci.yml.

020f78c

Signed-off-by: Federico Di Pierro <[email protected]>

update(ci): added proper iam role to master CI.

65cbbec

Renamed postsubmit to master. Fixes to PR ci. Signed-off-by: Federico Di Pierro <[email protected]>

chore(ci): added permissions to master CI.

9795fc2

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP dismissed stale reviews from maxgio92 and leogr via eae8f3b February 20, 2024 08:58

FedeDP force-pushed the new/gha branch from 6f68fb7 to eae8f3b Compare February 20, 2024 08:58

FedeDP added 3 commits February 20, 2024 10:00

cleanup(ci): comment circleci workflow.

7f1ce98

Signed-off-by: Federico Di Pierro <[email protected]>

chore(ci): use actions/checkout v4.

989cdd4

Signed-off-by: Federico Di Pierro <[email protected]>

chore(ci): added concurrency for CI and master workflows.

d4fea04

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP force-pushed the new/gha branch from 2526185 to d4fea04 Compare February 20, 2024 09:00

chore(ci): renamed master.yaml to master.yml.

8e42a6e

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP force-pushed the new/gha branch from 4c3d9f9 to 8e42a6e Compare February 20, 2024 09:36

poiana removed the do-not-merge/hold label Feb 20, 2024

LucaGuerra approved these changes Feb 20, 2024

View reviewed changes

poiana assigned LucaGuerra Feb 20, 2024

poiana added the do-not-merge/hold label Feb 20, 2024

leogr approved these changes Feb 20, 2024

View reviewed changes

poiana removed the do-not-merge/hold label Feb 20, 2024

poiana merged commit 5a7e666 into master Feb 20, 2024
5 checks passed

poiana deleted the new/gha branch February 20, 2024 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new(ci): added gha. #961

new(ci): added gha. #961

FedeDP commented Jan 20, 2023

FedeDP commented Jan 20, 2023

LucaGuerra commented Jan 20, 2023

maxgio92 commented Jan 20, 2023 •

edited

Loading

LucaGuerra commented Jan 20, 2023

poiana commented Apr 20, 2023

FedeDP commented Apr 20, 2023

FedeDP commented May 17, 2023

FedeDP commented May 17, 2023

FedeDP commented May 17, 2023

leogr commented May 18, 2023

FedeDP commented May 18, 2023

leogr commented May 18, 2023

poiana commented Aug 16, 2023

poiana commented Feb 19, 2024

FedeDP commented Feb 19, 2024

FedeDP commented Feb 20, 2024

FedeDP commented Feb 20, 2024

leogr left a comment

poiana commented Feb 20, 2024

FedeDP commented Feb 20, 2024

new(ci): added gha. #961

new(ci): added gha. #961

Conversation

FedeDP commented Jan 20, 2023

FedeDP commented Jan 20, 2023

LucaGuerra commented Jan 20, 2023

maxgio92 commented Jan 20, 2023 • edited Loading

LucaGuerra commented Jan 20, 2023

poiana commented Apr 20, 2023

FedeDP commented Apr 20, 2023

FedeDP commented May 17, 2023

FedeDP commented May 17, 2023

FedeDP commented May 17, 2023

leogr commented May 18, 2023

FedeDP commented May 18, 2023

leogr commented May 18, 2023

poiana commented Aug 16, 2023

poiana commented Feb 19, 2024

FedeDP commented Feb 19, 2024

FedeDP commented Feb 20, 2024

FedeDP commented Feb 20, 2024

leogr left a comment

Choose a reason for hiding this comment

poiana commented Feb 20, 2024

FedeDP commented Feb 20, 2024

maxgio92 commented Jan 20, 2023 •

edited

Loading