feat: dns caching manager #1294
Conversation
This is done as tmdb ttl is very less like 40 seconds so to make sure any issues wont be caused due to cached dns (previously we were caching for 5 minutes no matter what ttl)
server/routes/settings/index.ts
Outdated
There was a problem hiding this comment.
This will be removed. It was for testing quickly
| // Add DNS caching | ||
| dns.lookup = (() => { | ||
| const wrappedLookup = function ( | ||
| hostname: string, | ||
| options: | ||
| | number | ||
| | dns.LookupOneOptions | ||
| | dns.LookupOptions | ||
| | dns.LookupAllOptions, | ||
| callback: ( | ||
| err: NodeJS.ErrnoException | null, | ||
| address: string | dns.LookupAddress[] | undefined, | ||
| family?: number | ||
| ) => void | ||
| ): void { | ||
| if (typeof options === 'function') { | ||
| callback = options; | ||
| options = {}; | ||
| } | ||
|
|
||
| dnsCache | ||
| .lookup(hostname) | ||
| .then((result) => { | ||
| if ((options as dns.LookupOptions).all) { | ||
| callback(null, [ | ||
| { address: result.address, family: result.family }, | ||
| ]); | ||
| } else { | ||
| callback(null, result.address, result.family); | ||
| } | ||
| }) | ||
| .catch((error) => { | ||
| callback(error, undefined, undefined); | ||
| }); | ||
| } as typeof dns.lookup; | ||
|
|
||
| (wrappedLookup as any).__promisify__ = async function ( | ||
| hostname: string, | ||
| options?: dns.LookupAllOptions | dns.LookupOneOptions | ||
| ): Promise<dns.LookupAddress[] | { address: string; family: number }> { | ||
| const result = await dnsCache.lookup(hostname); | ||
|
|
||
| if (options && 'all' in options && options.all === true) { | ||
| return [{ address: result.address, family: result.family }]; | ||
| } | ||
| return { address: result.address, family: result.family }; | ||
| }; | ||
|
|
||
| return wrappedLookup; | ||
| })(); | ||
|
|
There was a problem hiding this comment.
Couldn't you implement this inside the dnsCacheManagerItself? It floods the server a bit.
There was a problem hiding this comment.
The flood is coming from the debug logging right? Thats to be removed. I have it added rn to sort of test it. Or if not that what do you mean?
There was a problem hiding this comment.
No not that, i meant you could create a function inside server/utils/dnsCacheManager.ts that contains all this, because all this code to overwrite the lookup function takes a lot of space inside the startup function of the server.
There was a problem hiding this comment.
Ah. And then call it here?
| const cached = this.cache.get(hostname); | ||
| if (cached) { | ||
| const age = Date.now() - cached.timestamp; | ||
| const ttlRemaining = Math.max(0, cached.ttl - age); |
There was a problem hiding this comment.
What's the point of the Math.max? Your code would work the same without it
There was a problem hiding this comment.
I had some issues where ttl went to negative values. That's why
Description
(wip)
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed