Correct text #333
Open
Correct text #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "Each colors" to "Each color" to correctly use the singular. Clarified the description of "contrast ratio against when used on top of" to "contrast ratio when used on top of" to improve readability.
In the Auth Client section there is an extra comma after the last element in the items array
- **"You signed up"** → **"You signed in with:"**: more accurate description, appropriate for the authentication context. - **"Your signature"** → **"Your signed message"**: this better captures the essence of what is manifested in the `signature`
"SIWF message" - it should be "SIWE message" because SIWE (Sign In With Ethereum) is a message standard, not SIWF. "The Sign In With Farcaster URL" - it would be more correct to say "Sign In With Farcaster URL" without "The" because it is a specific URL in the context of this library. "AuthKit state" - it should be "Auth client state" because it is more related to the state of the authentication client.
Here "unauthenticated" should be replaced with "unauthenticated". In the context of technical descriptions, "URL" is usually written with capital letters.
|
@savvar9991 is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color Scale Documentation
XXX-softXXX-softAuthentication Documentation
You signed: {message}
You signed in with: {message}
Your signature: {signature}
Your signed message: {signature}
Sign-In Documentation
Frames Documentation