fix: don't force fetch message count for non-existent fids (#1653)

farcasterxyz · Feb 5, 2024 · d3cd9c9 · d3cd9c9
1 parent 618e6fa
commit d3cd9c9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/apps/hubble/src/storage/stores/storageCache.ts b/apps/hubble/src/storage/stores/storageCache.ts
@@ -132,9 +132,9 @@ export class StorageCache {
     log.info({ timeTakenMs: Date.now() - start, totalFids }, "storage cache prepopulation finished");
   }
 
-  async getMessageCount(fid: number, set: UserMessagePostfix): HubAsyncResult<number> {
+  async getMessageCount(fid: number, set: UserMessagePostfix, forceFetch = true): HubAsyncResult<number> {
     const key = makeKey(fid, set);
-    if (this._counts.get(key) === undefined) {
+    if (this._counts.get(key) === undefined && forceFetch) {
       let total = 0;
       await this._db.forEachIteratorByPrefix(
         makeMessagePrimaryKey(fid, set),

diff --git a/apps/hubble/src/storage/stores/store.ts b/apps/hubble/src/storage/stores/store.ts
@@ -242,7 +242,7 @@ export abstract class Store<TAdd extends Message, TRemove extends Message> {
   async pruneMessages(fid: number): HubAsyncResult<number[]> {
     const commits: number[] = [];
 
-    const cachedCount = await this._eventHandler.getCacheMessageCount(fid, this._postfix);
+    const cachedCount = await this._eventHandler.getCacheMessageCount(fid, this._postfix, false);
     const units = await this._eventHandler.getCurrentStorageUnitsForFid(fid);
 
     if (units.isErr()) {

diff --git a/apps/hubble/src/storage/stores/storeEventHandler.ts b/apps/hubble/src/storage/stores/storeEventHandler.ts
@@ -237,8 +237,8 @@ class StoreEventHandler extends TypedEmitter<StoreEvents> {
     });
   }
 
-  async getCacheMessageCount(fid: number, set: UserMessagePostfix): HubAsyncResult<number> {
-    return this._storageCache.getMessageCount(fid, set);
+  async getCacheMessageCount(fid: number, set: UserMessagePostfix, forceFetch = true): HubAsyncResult<number> {
+    return this._storageCache.getMessageCount(fid, set, forceFetch);
   }
 
   async getEarliestTsHash(fid: number, set: UserMessagePostfix): HubAsyncResult<Uint8Array | undefined> {