turbohash #171
Merged
turbohash #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suurkivi
commented
Dec 17, 2024
| assert_eq!(r.unwrap()[0], true); | ||
| assert_eq!(node.items(), 0); | ||
| assert_eq!(node.hash(), empty_hash()); | ||
| assert_eq!(node.hash(), Vec::<u8>::new()); |
There was a problem hiding this comment.
note a subtle change here
suurkivi
commented
Dec 17, 2024
| assert_eq!(r.unwrap()[0], true); | ||
| assert_eq!(node.items(), 0); | ||
| assert_eq!(node.hash(), empty_hash()); | ||
| assert_eq!(node.hash(), Vec::<u8>::new()); |
There was a problem hiding this comment.
note a subtle change here
| @@ -122,15 +124,25 @@ impl TrieNode { | |||
| for char in db_trie_node.child_chars { | |||
| children.insert( | |||
| char as u8, | |||
| TrieNodeType::Serialized(SerializedTrieNode::new(None)), | |||
| TrieNodeType::Serialized(SerializedTrieNode::new()), | |||
There was a problem hiding this comment.
If the struct is empty, do we actually need the struct?
There was a problem hiding this comment.
left a TODO comment
suurkivi
force-pushed
the
js/turbohash
branch
3 times, most recently
from
22bb674 to
d0d04ba
Compare
suurkivi
force-pushed
the
js/turbohash
branch
from
d0d04ba to
866b31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stores the hash of a trie node in the node's parent (in a hashmap).
This yields an important performance improvement when recomputing the hash of a changed node. Previously, when recomputing the hash, as we are working our way up the trie, we had to load siblings of a changed node out of the db. In this version, the sibling hashes are already loaded, which dramatically reduces the number of db reads.