Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Malachite #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varun-doshi
Copy link

@varun-doshi varun-doshi commented Dec 23, 2024

Ref #181

This PR resulted in quite some changes, primarily due to breaking changes in Malachite v0.0.1 compared to the commit Snapchain was using previously.
There are many missing implementations in traits and Enums such as in SnapchainValidatorContext and Effect, TimeoutKind.
Another function that needs to be looked at is handle_msg in src/consensus/consensus.rs

@varunsrin
Copy link
Member

thanks for the pr, someone will review it soon

@varunsrin
Copy link
Member

also, can you comment on the issue so that i can assign it to you @varun-doshi ?

@varunsrin varunsrin requested review from sanjayprabhu and aditiharini and removed request for sanjayprabhu December 24, 2024 14:24
@aditiharini
Copy link
Contributor

aditiharini commented Dec 24, 2024

Were you able to start up 3 nodes locally and see consensus progressing? This will likely not work until we propagate the gossip messages into consensus (i.e. do what we were previously doing for the Broadcast effect, but it's a good way to test that these changes have roughly worked as expected.
cargo run --bin setup_local_testnet
cargo run -- --config-path nodes/1/snapchain.toml
cargo run -- --config-path nodes/2/snapchain.toml
cargo run -- --config-path nodes/3/snapchain.toml

@aditiharini
Copy link
Contributor

So far this looks reasonable, let me know if it'd be useful to get some input on the remaining todos and/or figuring out where to plumb gossip messages through consensus.

@sds
Copy link
Member

sds commented Dec 24, 2024

You'll want to rebase the changes from #187 so that the Docker image builds. Tests are still failing however, so we'll want to make sure those are fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants