Fix y position of edit controls for small screens #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** On small screens - and the default farmOS layout - the controls often overlap or even go off the bottom of the map making them hard to use or completely inaccessible.
symbioquine
force-pushed
the
2.x-edit-control-vert-pos
branch
from
82512f4 to
3eacb5c
Compare
mstenta
approved these changes
Apr 7, 2022
|
Looking at these screenshots, won't the snapping grid still overlap? Except in farmOS/farmOS we have a larger height than these screenshots so it's not an issue there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? On small screens - and the default farmOS layout - the
controls often overlap or even go off the bottom of the map
making them hard to use or completely inaccessible.
Before:
After: