-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow2, librosa8, better plots #8
Conversation
Gentle nudge on this one, since the reported librosa benchmarks are now two majors out of date 😁 |
sorry again especially, since I am aware that this should be addressed soon as I never wanted to make librosa look bad in this...
|
@bmcfee regarding 3. I guess the easiest is to have fixed matrix of supported pairs of codecs and libs that will be tested instead of using try/except... |
Sure, happy to!
That's fine -- it was just a suggestion. I generally have a preference toward raw data over aggregates, but if it's too unwieldy here, there's no problem leaving it as is.
Hrm, indeed. I guess you could do a length check (expected # of samples) if you don't want to do a full inspection of the data.
That's probably a safer option, but a lot more work I'm guessing. |
@bmcfee a problem with 1. is that tf.data pipelines need to be compiled for each file. That would make the comparison between frameworks (np vs torch vs tf) useless as tf would probably be last. Still it would be meaningful to give relative results: aka. which loading method is the fasted for each tensor lib. Would you say this is worth it then? |
Yeah, that's tricky. Maybe worth reporting two versions in that case, one of which factors out the compilation time? |
@bmcfee i think its better to merge this now than waiting another year... sorry for this. |
Thanks @faroit ! I'm just happy to see the version updates. 😁 |
Bug fixes