forked from k-sys/covid-19
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework graphic layout. Implement negative case method. Add notebook for non-US data #1
Open
pati610
wants to merge
27
commits into
farr:master
Choose a base branch
from
pati610:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc for graphs. new runs. new png graphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Will,
I've spent a lot of time digging into your model, and intuitively – as well as logically, and visually – it strikes me as being very sound. I've reworked the graph layout to resemble the rt.live theme for easier comparison(Stan R0 US.ipynb), and I've also made a country-based notebook (Stan R0 EUW.ipynb), for now fetching mainly EU data but adjustable to include any country. I deliberately left your and Kevin's notebooks untouched.
The other modifications I've implemented are listed in the readme file in my repo.
I've put high res png files of the last runs in my
image
folder. It makes for some very interesting reading. One thing that strikes me in particular is how well your model lines up with the graphs at epiforecasts. There seems to be a slight skewness date-wise, but the curvatures are generally a close match.Strangely enough, the graphs I get using the US mcmc model for the that was the prototype for rt.live are nowhere close to what's published on their web page, but I guess they've moved on without updating the git repo.
To add to the confusion: Running both the mcmc and Stan models on EU countries, your model is much more in line with their estimates.
Thanks for documenting your method so well, I learned a lot from the process.
I'm thinking about making a graphic layout in the epiforecast style as well, which probably would aid in the side-by-side comparison.