move nbdev detection to fastcore #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hamelsmu
commented
Sep 18, 2024
| return cfg_path/cfg_name | ||
|
|
||
| # %% ../nbs/13_nbdev.ipynb | ||
| def is_nbdev(): |
There was a problem hiding this comment.
I would normally make this a one-liner, but I think having a a docstring is good for LLMs?
|
I don't think it makes sense to create a new submodule just for this. Have a look at #628 and see if we can use that in llms-txt and nbdev instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates nbdev detection to fastcore. Once we review this PR we need to re-run the CI in this PR fastai/nbdev#1449