bench: allow users to run benchmarks non-interactively #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to run benchmarks non-interactively by using command line flags. Useful when running benchmarks automatically on CI environments, for example.
|
Would you mind to rebase/update this? I think #106 made some of these already. |
|
Will do when I'm back from vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to run benchmarks non-interactively by using command
line flags. Useful when running benchmarks automatically on CI
environments, for example.
Kind of an alternative to 9dc8d90#diff-6f09bc424586c395b13fd6f33fc863bcR8-R69 using commander to handle CLI parameters. I only saw that PR after I made this commit, thought I'd share anyway in case you want to go with this approach instead.
Checklist
npm run testandnpm run benchmark