Make SyntaxError include the line number in the message (#15)

fastify · Sep 25, 2018 · 6c75958 · 6c75958
1 parent 0fe3a14
commit 6c75958
Show file tree

Hide file tree

Showing 18 changed files with 47 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -52,6 +52,12 @@ module.exports = function (fastify, opts, next) {
               fastify.register(plugin, pluginOptions)
             }
           } catch (err) {
+            // Hack SyntaxError message so that we provide
+            // the line number to the user, otherwise they
+            // will be left in the cold.
+            if (err instanceof SyntaxError) {
+              err.message += ' at ' + err.stack.split('\n')[0]
+            }
             next(err)
             return
           }

diff --git a/package.json b/package.json
@@ -4,7 +4,7 @@
   "description": "Require all plugins in a directory",
   "main": "index.js",
   "scripts": {
-    "test": "standard | snazzy && tap test.js"
+    "test": "standard | snazzy && tap test/*.js"
   },
   "repository": {
     "type": "git",
@@ -36,5 +36,10 @@
   },
   "dependencies": {
     "steed": "^1.1.3"
+  },
+  "standard": {
+    "ignore": [
+      "test/error/lib/a.js"
+    ]
   }
 }
diff --git a/test.js → test/basic.js b/test.js → test/basic.js
@@ -7,7 +7,7 @@ t.plan(29)
 
 const app = Fastify()
 
-app.register(require('./fixtures/app'))
+app.register(require('./basic/app'))
 
 app.ready(function (err) {
   t.error(err)

diff --git a/fixtures/app.js → test/basic/app.js b/fixtures/app.js → test/basic/app.js
@@ -1,7 +1,7 @@
 'use strict'
 
 const path = require('path')
-const AutoLoad = require('..')
+const AutoLoad = require('../..')
 
 module.exports = function (fastify, opts, next) {
   fastify.register(AutoLoad, {

diff --git a/fixtures/defaultPrefix/defaultPrefix.js → test/basic/defaultPrefix/defaultPrefix.js b/fixtures/defaultPrefix/defaultPrefix.js → test/basic/defaultPrefix/defaultPrefix.js
diff --git a/fixtures/defaultPrefix/noDefaultPrefix.js → test/basic/defaultPrefix/noDefaultPrefix.js b/fixtures/defaultPrefix/noDefaultPrefix.js → test/basic/defaultPrefix/noDefaultPrefix.js
diff --git a/fixtures/defaultPrefix/overridePrefix.js → test/basic/defaultPrefix/overridePrefix.js b/fixtures/defaultPrefix/overridePrefix.js → test/basic/defaultPrefix/overridePrefix.js
diff --git a/fixtures/defaultPrefix/prefixed.js → test/basic/defaultPrefix/prefixed.js b/fixtures/defaultPrefix/prefixed.js → test/basic/defaultPrefix/prefixed.js
diff --git a/fixtures/foo/bar/index.js → test/basic/foo/bar/index.js b/fixtures/foo/bar/index.js → test/basic/foo/bar/index.js
diff --git a/fixtures/foo/ignored.test.js → test/basic/foo/ignored.test.js b/fixtures/foo/ignored.test.js → test/basic/foo/ignored.test.js
diff --git a/fixtures/foo/options.js → test/basic/foo/options.js b/fixtures/foo/options.js → test/basic/foo/options.js
diff --git a/fixtures/foo/prefixed.js → test/basic/foo/prefixed.js b/fixtures/foo/prefixed.js → test/basic/foo/prefixed.js
diff --git a/fixtures/foo/skipAutoload.js → test/basic/foo/skipAutoload.js b/fixtures/foo/skipAutoload.js → test/basic/foo/skipAutoload.js
diff --git a/fixtures/foo/something.js → test/basic/foo/something.js b/fixtures/foo/something.js → test/basic/foo/something.js
diff --git a/fixtures/foo/something.sh → test/basic/foo/something.sh b/fixtures/foo/something.sh → test/basic/foo/something.sh
diff --git a/test/error.js b/test/error.js
@@ -0,0 +1,15 @@
+'use strict'
+
+const t = require('tap')
+const Fastify = require('fastify')
+
+t.plan(2)
+
+const app = Fastify()
+
+app.register(require('./error/app'))
+
+app.ready(function (err) {
+  t.type(err, SyntaxError)
+  t.match(err.message, /Unexpected token \} at .*\/test\/error\/lib\/a.js:6/)
+})
diff --git a/test/error/app.js b/test/error/app.js
@@ -0,0 +1,12 @@
+'use strict'
+
+const path = require('path')
+const AutoLoad = require('../..')
+
+module.exports = function (fastify, opts, next) {
+  fastify.register(AutoLoad, {
+    dir: path.join(__dirname, 'lib')
+  })
+
+  next()
+}
diff --git a/test/error/lib/a.js b/test/error/lib/a.js
@@ -0,0 +1,6 @@
+'use strict'
+
+module.exports = function (app, opts, next) {
+  // this has a syntax error on purpose
+  [
+}