-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include directoryPrefix when using autoPrefix #350
Open
KcZer0
wants to merge
2
commits into
fastify:master
Choose a base branch
from
KcZer0:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
'use strict' | ||
|
||
module.exports = function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ indexNested: true }) | ||
}) | ||
|
||
next() | ||
} |
11 changes: 11 additions & 0 deletions
11
test/commonjs/basic/defaultPrefix/nested/noDefaultPrefix.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
'use strict' | ||
|
||
module.exports = function (f, opts, next) { | ||
f.get('/noPrefixNested', (request, reply) => { | ||
reply.send({ no: 'prefixNested' }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
module.exports.prefixOverride = '' |
13 changes: 13 additions & 0 deletions
13
test/commonjs/basic/defaultPrefix/nested/overridePrefix.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
'use strict' | ||
|
||
module.exports = function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ overide: 'prefixNested' }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
module.exports.autoPrefix = '/notUsed' | ||
|
||
module.exports.prefixOverride = '/overriddenPrefixNested' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
'use strict' | ||
|
||
module.exports = function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ prefixedNested: true }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
module.exports.autoPrefix = '/prefixedNested' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
'use strict' | ||
|
||
export default function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ indexNested: true }) | ||
}) | ||
|
||
next() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
'use strict' | ||
|
||
export default function (f, opts, next) { | ||
f.get('/noPrefixNested', (request, reply) => { | ||
reply.send({ no: 'prefixNested' }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
export const prefixOverride = '' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
'use strict' | ||
|
||
export default function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ overide: 'prefixNested' }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
export const autoPrefix = '/notUsed' | ||
|
||
export const prefixOverride = '/overriddenPrefixNested' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
'use strict' | ||
|
||
export default function (f, opts, next) { | ||
f.get('/', (request, reply) => { | ||
reply.send({ prefixedNested: true }) | ||
}) | ||
|
||
next() | ||
} | ||
|
||
export const autoPrefix = '/prefixedNested' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change necessary due to the change in the fixture, or is this a breaking change?
Can you please not alter existing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. Yes it is breaking change.
The behaviour between dirNameRoutePrefix and autoPrefix was not properly defined in the docs before this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intended behaviour in the changed test is to override directoryPrefix, but keep
options.prefix
, I think a new exported optionplugin.directoryOverride
would be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid a breaking change, thanks.