This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
decorate reply with writeEarlyHints #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
suggested changes
Sep 29, 2022
index.js
Outdated
| if (raw.socket) { | ||
| raw.socket.write(serialized, 'utf-8', resolve) | ||
| } else { | ||
| raw.write(serialized, 'utf-8', resolve) |
There was a problem hiding this comment.
socket can be null. In that case we use raw.write.
I would actually also prefer to know why socket is null sometimes. Any idea?
There was a problem hiding this comment.
If socket is null we should not be writing early hints at all.
There was a problem hiding this comment.
If socket is null it means there is no actual socket behind the request, i.e. the request was aborted.
index.js
Outdated
| const serialized = serialize(earlyHints) | ||
| return new Promise(resolve => { | ||
| if (raw.socket) { | ||
| raw.socket.write(serialized, 'utf-8', resolve) |
There was a problem hiding this comment.
note that the callback of write() could have an err as the first argument, which unfortunately means we should reject the promise.
|
closing in favor of #5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct