-
-
Notifications
You must be signed in to change notification settings - Fork 132
Conversation
src/scripts/downloadReleases.js
Outdated
// TODO: ----------------------------------------------------------------------- debug | ||
.concat([ | ||
{ | ||
name: 'v3.0.0-alpha', | ||
zipball_url: 'https://api.github.com/repos/fastify/fastify/zipball/v1.13.3' | ||
}, | ||
{ | ||
name: 'v3.0.0-alpha.2', | ||
zipball_url: 'https://api.github.com/repos/fastify/fastify/zipball/v1.13.3' | ||
} | ||
]) | ||
// TODO: ----------------------------------------------------------------------- end of debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is used to simulate two upcoming alpha release, it will be removed before the merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only a question:
when you switch version in a page (like decorators for ex), the user is sent to the TOC, could we maintain the path changing only the version-path-param?
In theory yes, in practice that page might not exist in another version. Not sure right now what would be a better way to handle this to be honest without having to map all the possible pages in advance. |
…st-doc-to-last-stable-release
@Eomm, actually, on a second thought, there might be a way to achieve that. The question is,
|
I'd make it a follow-up PR. |
@jsumners makes sense. Then I will merge this and I will create a dedicated issue to discuss this other potential improvement :) |
Closes #157
This PR changes the current behaviour to point to the
latest
documentation and provides some high-level refactoring of the build process code.As discussed in #157, the new behaviour is the following:
latest
doesn't track tomaster
anymore, the 2 tags are now independentlatest
will point to the most recent version that does not include annotation (as for instance -alpha.1)master
tracks to actualmaster
(this is unchanged)I created a fake
v3.0.0-alpha
to test these assumptions. You can see a preview in the demo below.Please help me to test this thoroughly before we ship any change :)
DEMO: https://latest-doc-to-last-stable-release.surge.sh/