cache/core: update docs for request headers in transactions #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to set request headers in write options for Transaction.Insert or Transaction.InsertAndStreamBack returns ErrInvalidArgument. The docs previously only stated this for Transaction.Update.
|
Do you have a link to the Rust SDK docs or other source for this change? |
|
The best I have here is https://docs.rs/fastly/latest/fastly/cache/core/struct.TransactionInsertBuilder.html#method.vary_by but it's not an exact mapping because the Rust SDK uses the builder pattern and the Go SDK uses an options struct. This was found by a customer report, and then I found the error handling for this on the insert handler in the Compute platform's code. I can follow up with you privately with the links to those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to set request headers in write options for
Transaction.Insert or Transaction.InsertAndStreamBack returns
ErrInvalidArgument. The docs previously only stated this for
Transaction.Update.