StarlingMonkey WPT tests #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From 132 failures initially, there are now just a few WPT tests left to pass:
|
guybedford
force-pushed
the
starlingmonkey-wpt
branch
from
a4e6fb0
to
77180fc
Compare
guybedford
force-pushed
the
starlingmonkey-wpt
branch
from
9dd4641
to
e58bf3d
Compare
elliottt
reviewed
Jun 22, 2024
Co-authored-by: Trevor Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the WPT tests for the StarlingMonkey port on CI.
In the process StarlingMonkey is updated to the latest version, including with the upstream fixes:
It also turns out StarlingMonkey was actually passing one extra WPT than our build. To resolve that this PR also updates our
rust-urlcrate to the latest and to line up with StarlingMonkey's implementation, which replaces #806. The remaining port TODOs are also completed here.