Use next_rails namespace on spec tests. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
commented
May 19, 2024
| require "tempfile" | ||
| require_relative "spec_helper" | ||
| require_relative "../lib/deprecation_tracker" |
There was a problem hiding this comment.
This case we still need the require_relatvie because the deprecation_tracker class is out of the next_rails namespace. 👍
JuanVqz
commented
May 19, 2024
| expect(output).to match "gems incompatible with Rails 7.0" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
All these tests were moved from spec/bundle_report_spec.rb
JuanVqz
commented
May 19, 2024
JuanVqz
force-pushed
the
fix-namespace-specs
branch
2 times, most recently
from
268760f to
23a499f
Compare
JuanVqz
requested review from
etagwerker,
arielj,
fbuys and
rishijain
and removed request for
fbuys
JuanVqz
force-pushed
the
fix-namespace-specs
branch
from
23a499f to
6d20ef4
Compare
julioalucero
reviewed
Aug 6, 2024
|
|
||
| RSpec.describe NextRails::GemInfo do | ||
| describe "#state" do |
There was a problem hiding this comment.
@JuanVqz we do not need these specs anymore? #state and #find_latest_compatible
There was a problem hiding this comment.
@julioalucero thank you for catching it! I fixed it already, please feel free to review it again when possible 👍
JuanVqz
force-pushed
the
fix-namespace-specs
branch
2 times, most recently
from
1b19c08 to
91714b2
Compare
|
Test for Ruby 3 are failing because it needs this fix bug first #125
|
JuanVqz
force-pushed
the
fix-namespace-specs
branch
2 times, most recently
from
a4cb607 to
a0d63b9
Compare
There were some not needed `require_relative` calls if the `spec` folder were ordered according to the `lib` folder. So, I removed them and organized the test suite accordingly the classes at library
JuanVqz
force-pushed
the
fix-namespace-specs
branch
from
a0d63b9 to
e9a816b
Compare
etagwerker
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some unnecessary
require_relativecalls in the spec files, so I removed them and organized the test suite according to the classes in the library folder.Motivation and Context
When creating additional classes within the NextRails namespace, it became challenging to utilize
require_relativecalls for loading the classes in spec files.How Has This Been Tested?
The test suite should still pass.
Screenshots:
I will abide by the code of conduct