Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stereogram plot #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Souza-junior
Copy link
Member

Relevant issues/PRs:

These functions differ slightly from Harmonica's due to the convention in
paleomagnetism, where a positive vector is defined as downward.
For now the function only plots lines
@leouieda
Copy link
Member

@Souza-junior @YagoMCastro this would be much better as a matplotlib projection. That way matplotlib has tools to help draw grids, set ticks, etc. See https://matplotlib.org/stable/api/projections_api.html

@leouieda
Copy link
Member

Tests are failing because we need add matplotlib as a run-time dependency to pyproject.toml. The minimum required version should be a minor release from at least 2 years ago. Check the matplotlib changelog to see which one.

@leouieda
Copy link
Member

For testing, use the pytest-mpl plugin. It needs to be added to the environment.yml and env/requirements-test.txt files.

@leouieda
Copy link
Member

The matplotlib projection stuff could be a follow up PR later. @YagoMCastro could you open an issue for that, please?

@YagoMCastro
Copy link
Contributor

Thank you for the great work on this. I noticed that there is a class that currently contain only a single function. In these cases, it might be more efficient to substitute the class with just a standalone function. This could help simplify the code and improve readability. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants