-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stereogram plot #28
base: main
Are you sure you want to change the base?
Stereogram plot #28
Conversation
These functions differ slightly from Harmonica's due to the convention in paleomagnetism, where a positive vector is defined as downward.
For now the function only plots lines
@Souza-junior @YagoMCastro this would be much better as a matplotlib projection. That way matplotlib has tools to help draw grids, set ticks, etc. See https://matplotlib.org/stable/api/projections_api.html |
Tests are failing because we need add matplotlib as a run-time dependency to |
For testing, use the pytest-mpl plugin. It needs to be added to the |
The matplotlib projection stuff could be a follow up PR later. @YagoMCastro could you open an issue for that, please? |
Thank you for the great work on this. I noticed that there is a class that currently contain only a single function. In these cases, it might be more efficient to substitute the class with just a standalone function. This could help simplify the code and improve readability. What do you think? |
Relevant issues/PRs: