Skip to content

Commit

Permalink
resolving wrong reference (#438)
Browse files Browse the repository at this point in the history
* add static partition assignment possibilities

* add global partitions as actives as well

* pin mode as long we didn't switch to newest faust version that supports python 3.11

* first version of global global tables

* add GlobalGlobalTable Object

* have global global as attribute of global table

* use use_partitioner also for having all partitions as standby

* Update requirements.txt

* fix tests, assert that global flag is set in case global global is used, linting

* remove test artefact

* fix linting again

* rename global global to synchronize_all_active_partitions

* fix linting

* add base.py changes

* fixed synchornized_all_active_partitions attribute handling in GlobalTable Constructor

* resolved reference error self.table.use_partitioner -> table.usepartitioner

* run code formatter

Co-authored-by: Alexander Oberegger <[email protected]>
Co-authored-by: aoberegg <[email protected]>
Co-authored-by: Marco Julian Moser <[email protected]>
  • Loading branch information
4 people authored Jan 25, 2023
1 parent aaadab2 commit c20e11c
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions faust/assignor/partition_assignor.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,7 @@ def _global_table_standby_assignments(
# the table and consumer group B, C, D only consuming. With the
# synchronize_all_active_partitions flag it's possible to have
# shared state over multiple consumer groups.
if (
table.synchronize_all_active_partitions
or self.table.use_partitioner
):
if table.synchronize_all_active_partitions or table.use_partitioner:
standby_partitions = all_partitions
else: # Only add those partitions as standby which aren't active
standby_partitions = all_partitions - active_partitions
Expand Down

0 comments on commit c20e11c

Please sign in to comment.