Skip to content

Commit

Permalink
cran release
Browse files Browse the repository at this point in the history
  • Loading branch information
fawda123 committed Jul 16, 2023
1 parent 75fe811 commit 146fe53
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
7 changes: 3 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
## Resubmission

This is a version update to 2.4.3.
This is a version update to 2.5.0

## Test environments
* ubuntu 20.04 (on GitHub Actions), R 4.2.3
* ubuntu 20.04 (on GitHub Actions), R devel
* OS X (on GitHub Actions), R 4.2.3
* ubuntu 20.04 (devel, release, old release)
* OS X (on GitHub Actions), R 4.3.1
* win-builder [http://win-builder.r-project.org/](http://win-builder.r-project.org/) (devel, release, and old release)
* local Windows 10 install, R 4.2.3

Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/test-import_local.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ sample_data <- data.frame(
sample_data$datetimestamp <- strftime(sample_data$datetimestamp, format = '%m/%d/%Y %H:%M')
sample_file <- file.path(test_dir, "apadbwq.csv")
write.csv(sample_data, file = sample_file, row.names = FALSE)
zip(paste0(test_dir, 'apadwq.zip'), sample_file)
zip(paste0(test_dir, '\\apadwq.zip'), sample_file)

# generate sample met data
sample_metdata <- data.frame(
Expand Down Expand Up @@ -79,14 +79,14 @@ test_that("import_local raises an error for invalid station_code", {
})

test_that("import_local imports zip data correctly", {
result <- import_local(paste0(test_dir, 'apadwq'), 'apadbwq', trace = T)
result <- import_local(paste0(test_dir, '\\apadwq'), 'apadbwq', trace = T)
expect_equal(ncol(result), 3)
expect_equal(nrow(result), 217)
expect_s3_class(result, 'swmpr')
})

test_that("import_local returns error if files not found", {
expect_error(import_local(paste0(test_dir, 'apadwq'), 'asdfwq', trace = T))
expect_error(import_local(paste0(test_dir, '\\apadwq'), 'asdfwq', trace = T))
expect_error(import_local(dirname(sample_file), 'asdfwq', trace = T))
})

Expand Down

0 comments on commit 146fe53

Please sign in to comment.