build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.61.0 to…

… 6.3.0 (#1129)
fb55 · Aug 13, 2023 · 10df36e · 10df36e
1 parent 955905b
commit 10df36e
Show file tree

Hide file tree

Showing 8 changed files with 401 additions and 4,069 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -39,10 +39,10 @@
                 "dot-notation": 0,
                 "curly": [2, "multi-line"],
 
-                "@typescript-eslint/prefer-for-of": 0,
-                "@typescript-eslint/member-ordering": 0,
-                "@typescript-eslint/explicit-function-return-type": 0,
-                "@typescript-eslint/no-unused-vars": 0,
+                "@typescript-eslint/no-unused-vars": [
+                    2,
+                    { "argsIgnorePattern": "^_" }
+                ],
                 "@typescript-eslint/no-use-before-define": [
                     2,
                     { "functions": false }
@@ -58,8 +58,11 @@
                 "@typescript-eslint/prefer-includes": 2,
                 "@typescript-eslint/no-unnecessary-condition": 2,
                 "@typescript-eslint/switch-exhaustiveness-check": 2,
-                "@typescript-eslint/no-duplicate-imports": 2,
-                "@typescript-eslint/prefer-nullish-coalescing": 2
+                "@typescript-eslint/prefer-nullish-coalescing": 2,
+                "@typescript-eslint/consistent-type-imports": [
+                    2,
+                    { "prefer": "type-imports" }
+                ]
             }
         }
     ]

diff --git a/.github/workflows/nodejs-test.yml b/.github/workflows/nodejs-test.yml
@@ -11,6 +11,9 @@ env:
     FORCE_COLOR: 2
     NODE_COV: lts/* # The Node.js version to run coveralls on
 
+permissions:
+    contents: read #  to fetch code (actions/checkout)
+
 jobs:
     lint:
         runs-on: ubuntu-latest
@@ -24,16 +27,20 @@ jobs:
             - run: npm run lint
 
     test:
+        permissions:
+            contents: read #  to fetch code (actions/checkout)
+            checks: write #  to create new checks (coverallsapp/github-action)
+
         name: Node ${{ matrix.node }}
         runs-on: ubuntu-latest
 
         strategy:
             fail-fast: false
             matrix:
                 node:
-                    - 14
                     - 16
                     - 18
+                    - 20
                     - lts/*
 
         steps:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -35,11 +35,11 @@
     "devDependencies": {
         "@types/boolbase": "^1.0.1",
         "@types/jest": "^29.5.3",
-        "@types/node": "^20.4.9",
-        "@typescript-eslint/eslint-plugin": "^5.61.0",
-        "@typescript-eslint/parser": "^5.62.0",
+        "@types/node": "^20.4.10",
+        "@typescript-eslint/eslint-plugin": "^6.3.0",
+        "@typescript-eslint/parser": "^6.3.0",
         "cheerio-soupselect": "^0.1.1",
-        "eslint": "^8.46.0",
+        "eslint": "^8.47.0",
         "eslint-config-prettier": "^9.0.0",
         "htmlparser2": "^9.0.0",
         "jest": "^29.6.2",

diff --git a/src/compile.ts b/src/compile.ts
@@ -1,4 +1,5 @@
-import { Selector, SelectorType } from "css-what";
+import type { Selector } from "css-what";
+import { SelectorType } from "css-what";
 import * as boolbase from "boolbase";
 import {
     sortRules,

diff --git a/src/helpers/cache.spec.ts b/src/helpers/cache.spec.ts
@@ -4,6 +4,11 @@ import * as DomUtils from "domutils";
 import type { Element, Node } from "domhandler";
 import * as CSSselect from "../index.js";
 import { cacheParentResults } from "./cache.js";
+import type { InternalOptions } from "../types.js";
+
+const cacheParentResultsOptions = {
+    adapter: DomUtils,
+} as unknown as InternalOptions<Node, Element>;
 
 describe("cacheParentResults", () => {
     it("should rely on parent for matches", () => {
@@ -14,7 +19,7 @@ describe("cacheParentResults", () => {
         const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
         const hasfoo = cacheParentResults<Node, Element>(
             boolbase.trueFunc,
-            { adapter: DomUtils } as any,
+            cacheParentResultsOptions,
             fn,
         );
 
@@ -43,7 +48,7 @@ describe("cacheParentResults", () => {
         const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
         const hasfoo = cacheParentResults<Node, Element>(
             boolbase.trueFunc,
-            { adapter: DomUtils } as any,
+            cacheParentResultsOptions,
             fn,
         );
 
@@ -72,7 +77,7 @@ describe("cacheParentResults", () => {
         const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
         const hasfoo = cacheParentResults<Node, Element>(
             boolbase.trueFunc,
-            { adapter: DomUtils } as any,
+            cacheParentResultsOptions,
             fn,
         );
 

diff --git a/src/helpers/selectors.ts b/src/helpers/selectors.ts
@@ -1,7 +1,7 @@
 import type { InternalSelector } from "../types.js";
 import {
     AttributeAction,
-    AttributeSelector,
+    type AttributeSelector,
     SelectorType,
     isTraversal as isTraversalBase,
     type Traversal,

diff --git a/src/pseudo-selectors/index.ts b/src/pseudo-selectors/index.ts
@@ -13,7 +13,7 @@
  * Pseudos should be used to implement simple checks.
  */
 import type { CompiledQuery, InternalOptions, CompileToken } from "../types.js";
-import { parse, PseudoSelector } from "css-what";
+import { parse, type PseudoSelector } from "css-what";
 import { filters } from "./filters.js";
 import { pseudos, verifyPseudoArgs } from "./pseudos.js";
 import { aliases } from "./aliases.js";