Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.61.0 to 6.3.0 #1129

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"dot-notation": 0,
"curly": [2, "multi-line"],

"@typescript-eslint/prefer-for-of": 0,
"@typescript-eslint/member-ordering": 0,
"@typescript-eslint/explicit-function-return-type": 0,
"@typescript-eslint/no-unused-vars": 0,
"@typescript-eslint/no-unused-vars": [
2,
{ "argsIgnorePattern": "^_" }
],
"@typescript-eslint/no-use-before-define": [
2,
{ "functions": false }
Expand All @@ -58,8 +58,11 @@
"@typescript-eslint/prefer-includes": 2,
"@typescript-eslint/no-unnecessary-condition": 2,
"@typescript-eslint/switch-exhaustiveness-check": 2,
"@typescript-eslint/no-duplicate-imports": 2,
"@typescript-eslint/prefer-nullish-coalescing": 2
"@typescript-eslint/prefer-nullish-coalescing": 2,
"@typescript-eslint/consistent-type-imports": [
2,
{ "prefer": "type-imports" }
]
}
}
]
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/nodejs-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ env:
FORCE_COLOR: 2
NODE_COV: lts/* # The Node.js version to run coveralls on

permissions:
contents: read # to fetch code (actions/checkout)

jobs:
lint:
runs-on: ubuntu-latest
Expand All @@ -24,16 +27,20 @@ jobs:
- run: npm run lint

test:
permissions:
contents: read # to fetch code (actions/checkout)
checks: write # to create new checks (coverallsapp/github-action)

name: Node ${{ matrix.node }}
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node:
- 14
- 16
- 18
- 20
- lts/*

steps:
Expand Down
4,420 changes: 368 additions & 4,052 deletions package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"devDependencies": {
"@types/boolbase": "^1.0.1",
"@types/jest": "^29.5.3",
"@types/node": "^20.4.9",
"@typescript-eslint/eslint-plugin": "^5.61.0",
"@typescript-eslint/parser": "^5.62.0",
"@types/node": "^20.4.10",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"cheerio-soupselect": "^0.1.1",
"eslint": "^8.46.0",
"eslint": "^8.47.0",
"eslint-config-prettier": "^9.0.0",
"htmlparser2": "^9.0.0",
"jest": "^29.6.2",
Expand Down
3 changes: 2 additions & 1 deletion src/compile.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Selector, SelectorType } from "css-what";
import type { Selector } from "css-what";
import { SelectorType } from "css-what";
import * as boolbase from "boolbase";
import {
sortRules,
Expand Down
11 changes: 8 additions & 3 deletions src/helpers/cache.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ import * as DomUtils from "domutils";
import type { Element, Node } from "domhandler";
import * as CSSselect from "../index.js";
import { cacheParentResults } from "./cache.js";
import type { InternalOptions } from "../types.js";

const cacheParentResultsOptions = {
adapter: DomUtils,
} as unknown as InternalOptions<Node, Element>;

describe("cacheParentResults", () => {
it("should rely on parent for matches", () => {
Expand All @@ -14,7 +19,7 @@ describe("cacheParentResults", () => {
const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
const hasfoo = cacheParentResults<Node, Element>(
boolbase.trueFunc,
{ adapter: DomUtils } as any,
cacheParentResultsOptions,
fn,
);

Expand Down Expand Up @@ -43,7 +48,7 @@ describe("cacheParentResults", () => {
const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
const hasfoo = cacheParentResults<Node, Element>(
boolbase.trueFunc,
{ adapter: DomUtils } as any,
cacheParentResultsOptions,
fn,
);

Expand Down Expand Up @@ -72,7 +77,7 @@ describe("cacheParentResults", () => {
const fn = jest.fn((elem) => DomUtils.getText(elem).includes("foo"));
const hasfoo = cacheParentResults<Node, Element>(
boolbase.trueFunc,
{ adapter: DomUtils } as any,
cacheParentResultsOptions,
fn,
);

Expand Down
2 changes: 1 addition & 1 deletion src/helpers/selectors.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { InternalSelector } from "../types.js";
import {
AttributeAction,
AttributeSelector,
type AttributeSelector,
SelectorType,
isTraversal as isTraversalBase,
type Traversal,
Expand Down
2 changes: 1 addition & 1 deletion src/pseudo-selectors/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* Pseudos should be used to implement simple checks.
*/
import type { CompiledQuery, InternalOptions, CompileToken } from "../types.js";
import { parse, PseudoSelector } from "css-what";
import { parse, type PseudoSelector } from "css-what";
import { filters } from "./filters.js";
import { pseudos, verifyPseudoArgs } from "./pseudos.js";
import { aliases } from "./aliases.js";
Expand Down