Skip to content

Commit

Permalink
fix: package division main and dev/test
Browse files Browse the repository at this point in the history
  • Loading branch information
igobranco authored and jamoqs committed Dec 15, 2023
1 parent 30fc5c1 commit 07ed2e9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
9 changes: 2 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,10 @@ install-poetry: ## Install Poetry
@curl -sSL https://install.python-poetry.org | python -
.PHONY: install-poetry

install-packages: ## Install project dependencies without dev dependencies
@echo "Installing project dependencies..."
@$(POETRY) install --only main
.PHONY: install-packages

install-packages-dev: ## Install project dependencies with dev dependencies
install-packages: ## Install all project dependencies
@echo "Installing project dependencies..."
@$(POETRY) install
.PHONY: install-packages-dev
.PHONY: install-packages

logs: ## display docker app logs (follow mode)
@$(LOGS_DOCKER_DEV) -f nau-financial-app
Expand Down
8 changes: 4 additions & 4 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ RUN groupadd -r ${DOCKER_USER} && \
# Copy only requirements, to cache them in docker layer
COPY poetry.lock pyproject.toml /app/

# Install packages via poetry:
RUN poetry install --verbose
# Install core packages via poetry
RUN poetry install --verbose --only main

# Gunicorn
RUN mkdir -p /usr/local/etc/gunicorn
Expand Down Expand Up @@ -106,8 +106,8 @@ FROM core as development

ARG DOCKER_USER

# Install development dependencies
# TODO
# Install all dependencies, including development
RUN poetry install --verbose

# Un-privileged user running the application
USER ${DOCKER_USER}:${DOCKER_USER}
Expand Down

0 comments on commit 07ed2e9

Please sign in to comment.