Generate tests for Shared Revenue #106

apps/billing/factories.py

@@ -30,7 +30,7 @@ class Meta:
     payment_type = factory.fuzzy.FuzzyChoice(PAYMENT_TYPE)
     transaction_type = factory.Faker("random_element", elements=[t[0] for t in TRANSACTION_TYPE])
     transaction_date = factory.Faker(
-        "date_time_between", start_date="-1d", end_date="-5d", tzinfo=timezone.get_current_timezone()
+        "date_time_between", start_date="-5d", end_date="-1d", tzinfo=timezone.get_current_timezone()
     )
     document_id = factory.Faker("pystr_format", string_format="DCI-######{{random_int}}")
 
@@ -48,15 +48,17 @@ class Meta:
     description = factory.Faker("sentence")
     quantity = factory.Faker("pyint", min_value=1, max_value=10)
     vat_tax = factory.Faker("pydecimal", min_value=1, max_value=100, left_digits=3, right_digits=2)
-    amount_exclude_vat = factory.Faker("pydecimal", min_value=1, max_value=100, left_digits=5, right_digits=2)
     organization_code = factory.LazyAttribute(lambda obj: slugify(obj.description))
     product_code = "".join([random.choice(string.ascii_uppercase) for _ in range(5)])
 
     @factory.lazy_attribute
     def product_id(self):
         return f"course-v1:{self.organization_code}+{self.product_code}+2023_T3"
 
-    # Assuming 20% VAT
+    @factory.lazy_attribute
+    def amount_exclude_vat(self):
+        return self.transaction.total_amount_exclude_vat
+
     @factory.lazy_attribute
     def amount_include_vat(self):
-        return round(self.amount_exclude_vat * Decimal("1.20"), 2)
+        return round(self.transaction.total_amount_exclude_vat * Decimal("1.20"), 2)

apps/shared_revenue/factories.py

@@ -1,6 +1,3 @@
-import random
-import string
-
 import factory
 from django.utils import timezone
 from factory.django import DjangoModelFactory
@@ -14,8 +11,9 @@ class Meta:
 
     organization = None
     partner_percentage = 0.70
-    product_id = (
-        f"course-v1:UPorto+CBN{random.choice(string.ascii_uppercase)}{random.choice(string.ascii_uppercase)}F+2023_T3"
+    product_id = factory.Faker(
+        "pystr_format",
+        string_format="course-v%:?????+CBN???F+2023_T3",
     )
     start_date = factory.Faker(
         "date_time_between", start_date="-10d", end_date="+30d", tzinfo=timezone.get_current_timezone()

apps/shared_revenue/models.py

@@ -131,10 +131,7 @@ def has_concurrent_revenue_configuration(self) -> bool:
     def _check_partner_percentage(self) -> None:
         try:
             same_configurations: list[RevenueConfiguration] = RevenueConfiguration.objects.filter(
-                **{
-                    "organization": self.organization,
-                    "product_id": self.product_id,
-                }
+                product_id=self.product_id
             )
 
             percentages = self.partner_percentage