Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception state on ilink web service #212 #228

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

Tiago-da-silva23
Copy link
Contributor

This PR includes the ilink exception handling, resolve #212.

Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to include a 404 test.
A test that mocks the iLink 404 document not found.
And test/check if the client is returning a 404 when the upstream getDocument returns a 404.

Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a commit to the branch that merge the mock function with its test.

It isn't a good practice to have a different function that is too tight with its test outside of test. So I've replaced it with a lambda.

I would like other solution, but this is more practical.

LGTM ✅

@igobranco igobranco merged commit 9a59710 into main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch exception state on ilink web service
2 participants