Create a division of install packages with poetry dev vs prod #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamoqs
force-pushed
the
206-divide-required-and-test-dependencies
branch
3 times, most recently
from
01ff1d2
to
220cc4f
Compare
igobranco
previously requested changes
Dec 15, 2023
There was a problem hiding this comment.
I think the factory-boy and pytest-django should be on development dependencies.
The Dockerfile should also be changed... in reality this file is the most important to change. Because I won't like to have factory, pytest, black, etc... on the production image.
Comment on lines
+37
to
+38
| factory-boy = "^3.3.0" | ||
| pytest-django = "^4.5.2" |
There was a problem hiding this comment.
Factory stuff is normal used for testing...
Also the pytest stuff...
jamoqs
force-pushed
the
206-divide-required-and-test-dependencies
branch
from
220cc4f
to
ea5ec65
Compare
Tiago-da-silva23
approved these changes
Dec 15, 2023
|
@jamoqs view my comments please and create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds poetry option to install prod vs dev using --only main and make default install with this option Closed #206