Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package division main and dev/test #239

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: package division main and dev/test #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,10 @@ install-poetry: ## Install Poetry
@curl -sSL https://install.python-poetry.org | python -
.PHONY: install-poetry

install-packages: ## Install project dependencies without dev dependencies
@echo "Installing project dependencies..."
@$(POETRY) install --only main
.PHONY: install-packages

install-packages-dev: ## Install project dependencies with dev dependencies
install-packages: ## Install all project dependencies
@echo "Installing project dependencies..."
@$(POETRY) install
.PHONY: install-packages-dev
.PHONY: install-packages

logs: ## display docker app logs (follow mode)
@$(LOGS_DOCKER_DEV) -f nau-financial-app
Expand Down
8 changes: 4 additions & 4 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ RUN groupadd -r ${DOCKER_USER} && \
# Copy only requirements, to cache them in docker layer
COPY poetry.lock pyproject.toml /app/

# Install packages via poetry:
RUN poetry install --verbose
# Install core packages via poetry
RUN poetry install --verbose --only main

# Gunicorn
RUN mkdir -p /usr/local/etc/gunicorn
Expand Down Expand Up @@ -106,8 +106,8 @@ FROM core as development

ARG DOCKER_USER

# Install development dependencies
# TODO
# Install all dependencies, including development
RUN poetry install --verbose

# Un-privileged user running the application
USER ${DOCKER_USER}:${DOCKER_USER}
Expand Down
Loading