Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new show custom input method information to display option change #112

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

wengxt
Copy link
Member

@wengxt wengxt commented Jun 9, 2024

Instead of using system notification, which we do not have a long, descriptive string, use the input popup to display such information instead.

This can be easily achieved, by dispatch "option" notification in main thread to get the changed options. Since key event always happens in the main thread, we can guarantee that there is only one RimeState handling the key event. After that, try to aggregate based on the RimeOptionAction so the 3+ state option will not display multiple strings.

Fix #111

@wengxt wengxt requested a review from eagleoflqj June 9, 2024 00:40
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS with luna pinyin and a 3rd-party one.
Works as expected, and glad to see no hard-coded notifications.

src/rimestate.cpp Outdated Show resolved Hide resolved
Instead of using system notification, which we do not have a long,
descriptive string, use the input popup to display such information
instead.

This can be easily achieved, by dispatch "option" notification in main
thread to get the changed options. Since key event always happens in the
main thread, we can guarantee that there is only one RimeState handling
the key event. After that, try to aggregate based on the
RimeOptionAction so the 3+ state option will not display multiple
strings.

Fix #111
@wengxt wengxt merged commit 5cfb554 into master Jun 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fcitx5在利用快捷键切换Switch状态时右下角无状态显示的问题
2 participants