Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call refreshStatusArea in updateConfig. #77

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Call refreshStatusArea in updateConfig. #77

merged 1 commit into from
Oct 24, 2023

Conversation

rocka
Copy link
Member

@rocka rocka commented Oct 21, 2023

RimeEngine::updateConfig() calls RimeEngine::updateSchemaMenu() which would clear both schemaActions_ and optionActions_. Re-populate optionActions_ is needed afterwards.

fcitx5-rime/src/rimeengine.cpp

Lines 756 to 758 in 7568f67

void RimeEngine::updateSchemaMenu() {
schemActions_.clear();
optionActions_.clear();

This would fix empty status area after clicking "Reload Config" on Android (see 0:08 of the video in #76)

image

@wengxt wengxt merged commit 8553ff5 into fcitx:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocka @wengxt