Skip to content

Commit

Permalink
Update eslint and prettier (#1212)
Browse files Browse the repository at this point in the history
* chore: Update eslint and prettier config

* chore: Run prettier
  • Loading branch information
colebemis authored Aug 20, 2023
1 parent 9b401f0 commit 7cfd42c
Show file tree
Hide file tree
Showing 16 changed files with 1,724 additions and 1,615 deletions.
24 changes: 24 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
module.exports = {
env: {
browser: true,
es2021: true,
node: true,
},
extends: 'eslint:recommended',
overrides: [
{
env: {
node: true,
},
files: ['.eslintrc.{js,cjs}'],
parserOptions: {
sourceType: 'script',
},
},
],
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
},
rules: {},
};
17 changes: 0 additions & 17 deletions .eslintrc.json

This file was deleted.

6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/01-icon-request.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: 🙏 Icon request
description: Request a new icon
title: "Icon request: "
labels: ["icon request"]
projects: ["feathericons/1"]
title: 'Icon request: '
labels: ['icon request']
projects: ['feathericons/1']
body:
- type: input
id: icon-name
Expand Down
9 changes: 4 additions & 5 deletions .github/ISSUE_TEMPLATE/02-bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
name: 🐛 Bug report
description: Report a bug
title: "Bug: "
labels: ["bug"]
projects: ["feathericons/1"]
title: 'Bug: '
labels: ['bug']
projects: ['feathericons/1']
body:
- type: textarea
id: description
attributes:
label: Description
description: "Tell us more about the problem that you're running into."
placeholder: "e.g. When I try to do X, Y happens instead of Z"
placeholder: 'e.g. When I try to do X, Y happens instead of Z'
validations:
required: true
- type: textarea
Expand Down Expand Up @@ -70,4 +70,3 @@ body:
options:
- label: I have searched the existing issues to make sure this bug has not already been reported.
required: true

40 changes: 20 additions & 20 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@ jobs:
ci:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 16.x
cache: 'npm'
- name: Install dependencies
run: npm ci --legacy-peer-deps
- name: Build
run: npm run build
- name: Test
run: npm run test:coverage
- name: Lint
run: npm run lint
- name: Release
if: github.ref_name == 'main'
run: npx semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
- uses: actions/checkout@v3
- name: Use Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 16.x
cache: 'npm'
- name: Install dependencies
run: npm ci --legacy-peer-deps
- name: Build
run: npm run build
- name: Test
run: npm run test:coverage
- name: Lint
run: npm run lint
- name: Release
if: github.ref_name == 'main'
run: npx semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dist
coverage
24 changes: 12 additions & 12 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ orientation.
Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
- The use of sexualized language or imagery and unwelcome sexual attention or
advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
- Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities
Expand Down Expand Up @@ -71,4 +71,4 @@ This Code of Conduct is adapted from the [Contributor Covenant][homepage], versi
available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
[version]: http://contributor-covenant.org/version/1/4/
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ The following is a set of guidelines for contributing to Feather. Feel free to p
Pull requests for bug fixes and improvements are welcome. If you’re not sure if something is worth doing, please open an issue first.

**Working on your first Pull Request?** You can learn how from this *free* series
**Working on your first Pull Request?** You can learn how from this _free_ series
[How to Contribute to an Open Source Project on GitHub](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github).

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

- __Make your commit messages as descriptive as possible.__ Include as much information as you can. Explain anything that might be unclear.
- __Document your pull request__. Explain your changes, link to the relevant issue, and add screenshots when applicable.
- __Include only related work__. If you have unrelated changes, please split them into separate pull requests.
- **Make your commit messages as descriptive as possible.** Include as much information as you can. Explain anything that might be unclear.
- **Document your pull request**. Explain your changes, link to the relevant issue, and add screenshots when applicable.
- **Include only related work**. If you have unrelated changes, please split them into separate pull requests.

## Icon requests

To request a new icon, please fill out the [icon request form](https://github.com/feathericons/feather/issues/new?template=01-icon-request.yml).
Expand Down
Loading

0 comments on commit 7cfd42c

Please sign in to comment.