Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dove before after around utils #705

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 10 additions & 31 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
},
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking"
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:prettier/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
Expand All @@ -17,10 +18,11 @@
"plugins": [
"eslint-plugin-import",
"eslint-plugin-prefer-arrow",
"@typescript-eslint"
"@typescript-eslint",
"prettier"
],
"rules": {
"indent": ["warn", 2],
// "indent": ["warn", 2],
"prefer-rest-params": "off",
"prefer-spread": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
Expand Down Expand Up @@ -52,7 +54,7 @@
"@typescript-eslint/explicit-member-accessibility": [
"error",
{
"accessibility": "no-public"
"accessibility": "no-public"
}
],
"@typescript-eslint/naming-convention": "off",
Expand All @@ -68,10 +70,6 @@
"@typescript-eslint/prefer-for-of": "error",
"@typescript-eslint/prefer-function-type": "error",
"@typescript-eslint/prefer-namespace-keyword": "error",
"@typescript-eslint/quotes": [
"error",
"single"
],
"@typescript-eslint/triple-slash-reference": [
"error",
{
Expand All @@ -82,28 +80,16 @@
],
"@typescript-eslint/unified-signatures": "error",
"@typescript-eslint/consistent-type-imports": ["warn", { "prefer": "type-imports" }],
"@typescript-eslint/object-curly-spacing": ["warn", "always"],
"arrow-parens": [
"off",
"always"
],
"comma-dangle": "error",
"arrow-parens": ["off", "always"],
"complexity": "off",
"constructor-super": "error",
"eqeqeq": [
"error",
"smart"
],
"eqeqeq": ["error", "smart"],
"guard-for-in": "error",
"id-blacklist": "off",
"id-match": "off",
"import/order": "off",
// "jsdoc/check-alignment": "error",
// "jsdoc/check-indentation": "error",
// "jsdoc/newline-after-description": "error",
"max-classes-per-file": "off",
"max-len": "off",
"new-parens": "error",
"no-bitwise": "error",
"no-caller": "error",
"no-cond-assign": "error",
Expand All @@ -121,28 +107,21 @@
}
],
"no-throw-literal": "error",
"no-trailing-spaces": "error",
"no-undef-init": "error",
"no-underscore-dangle": "off",
"no-unsafe-finally": "error",
"no-unused-labels": "error",
"no-var": "error",
"object-shorthand": "error",
"one-var": [
"error",
"never"
],
"one-var": ["error", "never"],
"prefer-arrow/prefer-arrow-functions": "off",
"prefer-const": "error",
"radix": "error",
"space-before-function-paren": "error",
"spaced-comment": [
"error",
"always",
{
"markers": [
"/"
]
"markers": ["/"]
}
],
"use-isnan": "error",
Expand Down
11 changes: 11 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$schema": "http://json.schemastore.org/prettierrc",
"arrowParens": "avoid",
"bracketSpacing": true,
"printWidth": 100,
"semi": true,
"singleQuote": true,
"tabWidth": 2,
"bracketSameLine": false,
"htmlWhitespaceSensitivity": "ignore"
}
63 changes: 28 additions & 35 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,32 @@

## [Unreleased](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/HEAD)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v6.1.5...HEAD)
[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v7.0.0-pre.1...HEAD)

**Merged pull requests:**

- fix: add js extension to lodash imports [\#684](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/684) ([fratzinger](https://github.com/fratzinger))
- Update hooks documentation - setField [\#683](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/683) ([arnoldtkl](https://github.com/arnoldtkl))
- docs: add version to navbar [\#690](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/690) ([fratzinger](https://github.com/fratzinger))
- docs: add socialLinks [\#689](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/689) ([fratzinger](https://github.com/fratzinger))
- docs: move to vitepress [\#688](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/688) ([fratzinger](https://github.com/fratzinger))
- chore\(dependencies\): Update all dependencies [\#686](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/686) ([daffl](https://github.com/daffl))
- chore\(dependencies\): Update all dependencies [\#685](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/685) ([daffl](https://github.com/daffl))

## [v7.0.0-pre.1](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v7.0.0-pre.1) (2022-09-28)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v7.0.0-pre.0...v7.0.0-pre.1)

**Closed issues:**

- Types for populate don't account for the function param [\#629](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/629)
- Babel compile error [\#582](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/582)

## [v7.0.0-pre.0](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v7.0.0-pre.0) (2022-09-27)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v6.1.5...v7.0.0-pre.0)

**Closed issues:**

- Compatibility with future v5 \(aka Dove\) [\#687](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/687)

## [v6.1.5](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v6.1.5) (2022-07-31)

Expand All @@ -17,6 +37,11 @@

- Wrong lodash imports [\#674](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/674)

**Merged pull requests:**

- fix: add js extension to lodash imports [\#684](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/684) ([fratzinger](https://github.com/fratzinger))
- Update hooks documentation - setField [\#683](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/683) ([arnoldtkl](https://github.com/arnoldtkl))

## [v6.1.4](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v6.1.4) (2022-07-24)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v6.1.3...v6.1.4)
Expand Down Expand Up @@ -213,10 +238,6 @@

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v5.0.0...v5.0.1)

**Implemented enhancements:**

- Doument fgraphql [\#466](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/466)

**Closed issues:**

- TypeScript definition for fastJoin don't reflect examples for recursive resolvers [\#521](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/521)
Expand Down Expand Up @@ -363,7 +384,6 @@

- @feathersjs/commons dependency [\#492](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/492)
- Validation hook for restful api [\#491](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/491)
- TS for keep fgraphql [\#467](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/467)

**Merged pull requests:**

Expand All @@ -383,17 +403,11 @@
- update names and fix the options property [\#481](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/481) ([NickBolles](https://github.com/NickBolles))
- add typings for dialablePhoneNumber hook, add libphonenumber-js as a dependency [\#477](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/477) ([j2L4e](https://github.com/j2L4e))
- Add initial types for fgraphql [\#469](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/469) ([NickBolles](https://github.com/NickBolles))
- remove dtslint workaround in favor of npx [\#463](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/463) ([j2L4e](https://github.com/j2L4e))

## [v4.19.5](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.19.5) (2018-12-13)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.19.4...v4.19.5)

**Closed issues:**

- TS for keepQueryInArray [\#468](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/468)
- dtslint-build folder in installed package? [\#461](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/461)

## [v4.19.4](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.19.4) (2018-11-29)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.19.3...v4.19.4)
Expand Down Expand Up @@ -435,15 +449,6 @@

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.14...v4.18.0)

**Implemented enhancements:**

- Document KeepQueryInarray [\#465](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/465)

**Closed issues:**

- Difference between serialize and alterItems [\#464](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/464)
- softDelete2 returns error on delete [\#462](https://github.com/feathersjs-ecosystem/feathers-hooks-common/issues/462)

## [v4.17.14](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.17.14) (2018-11-01)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.13...v4.17.14)
Expand All @@ -452,26 +457,14 @@

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.12...v4.17.13)

**Merged pull requests:**

- Added support for dePopulate to fgraphql hook. [\#459](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/459) ([eddyystop](https://github.com/eddyystop))

## [v4.17.12](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.17.12) (2018-10-29)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.11...v4.17.12)

**Merged pull requests:**

- Added custom dePopulate func to dePopulate hook.' [\#458](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/458) ([eddyystop](https://github.com/eddyystop))

## [v4.17.11](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.17.11) (2018-10-26)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.10...v4.17.11)

**Merged pull requests:**

- Added fgraphql hook. [\#457](https://github.com/feathersjs-ecosystem/feathers-hooks-common/pull/457) ([eddyystop](https://github.com/eddyystop))

## [v4.17.10](https://github.com/feathersjs-ecosystem/feathers-hooks-common/tree/v4.17.10) (2018-09-26)

[Full Changelog](https://github.com/feathersjs-ecosystem/feathers-hooks-common/compare/v4.17.9...v4.17.10)
Expand Down
Loading