Skip to content

Commit

Permalink
BaseSteelTheme: be explicit about bold, italic, and underline
Browse files Browse the repository at this point in the history
If null, the previous TextFormat's value will be kept, so prefer false over null
  • Loading branch information
joshtynjala committed Feb 22, 2024
1 parent 03d265c commit 7f5afd9
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/feathers/themes/steel/BaseSteelTheme.hx
Original file line number Diff line number Diff line change
Expand Up @@ -402,35 +402,35 @@ class BaseSteelTheme extends ClassVariantTheme implements IDarkModeTheme {
}

private function getTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.fontSize, this.textColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.fontSize, this.textColor, false, false, false, null, null, align);
}

private function getDisabledTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.fontSize, this.disabledTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.fontSize, this.disabledTextColor, false, false, false, null, null, align);
}

private function getSecondaryTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.fontSize, this.secondaryTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.fontSize, this.secondaryTextColor, false, false, false, null, null, align);
}

private function getDangerTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.fontSize, this.dangerTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.fontSize, this.dangerTextColor, false, false, false, null, null, align);
}

private function getHeaderTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.headerFontSize, this.textColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.headerFontSize, this.textColor, false, false, false, null, null, align);
}

private function getDisabledHeaderTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.headerFontSize, this.disabledTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.headerFontSize, this.disabledTextColor, false, false, false, null, null, align);
}

private function getDetailTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.detailFontSize, this.secondaryTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.detailFontSize, this.secondaryTextColor, false, false, false, null, null, align);
}

private function getDisabledDetailTextFormat(align:TextFormatAlign = LEFT):TextFormat {
return new TextFormat(this.fontName, this.detailFontSize, this.disabledTextColor, null, null, null, null, null, align);
return new TextFormat(this.fontName, this.detailFontSize, this.disabledTextColor, false, false, false, null, null, align);
}

private function getHeaderFill():FillStyle {
Expand Down

0 comments on commit 7f5afd9

Please sign in to comment.