Fix CSS Inlining when using embedded image using Laravel 10 or 9.

[danhanly]

Added the suggested changes as seen here: #311

AbstractMultipartPart is a parent of both of the existing conditions, so it shouldn't change the functionality.

Tests pass.

[DannyvdSluijs]

Quoting from #311

When you were working on this, did you get this to work with Laravel 10 by making your suggested change?

@danhanly where the changes tested and could it cause issues with older versions of Laravel Framework?

[kirkbushell]

I've made this change locally and it changes nothing - I still have tailwind css class names in the HTML.

[DannyvdSluijs]

Hi @kirkbushell

Thanks for your feedback. Could you elaborate a bit more on which version you used, against which version of Laravel etc. Or maybe even share your repo, gist or just plain bits of code (so called reproduction steps) or other things you might have found during your testing, in order to move this PR forward.

[kirkbushell]

Hi @kirkbushell

Thanks for your feedback. Could you elaborate a bit more on which version you used, against which version of Laravel etc. Or maybe even share your repo, gist or just plain bits of code (so called reproduction steps) or other things you might have found during your testing, in order to move this PR forward.

Can see my issue here where I found the problem: #201

I think it needs to be documented on the project.

[danhanly]

Quoting from #311
where the changes tested and could it cause issues with older versions of Laravel Framework?

I've not tested it as I need it to support Laravel 10 before I'm able to consider integrating this into my project.

However, as I mentioned, the original condition compares against two classes AlternativePart and MixedPart both of which inherit from AbstractMultipartPart so there's no reason why it wouldn't work.

The existing test suite is comfortable with the change and the functionality continues regardless of it.

That being said, I know often this assurance isn't enough to warrant merging, since it could break compatibility. At the moment, I only have a Laravel 10 project in which to test this, so I can't verify it won't break previous versions, I'd appreciate it if someone could help test this in a previous laravel version.

I'm not certain this solves the underlying problem, since I was just actioning the suggestion made in #311 but I'm nearly at the point in my project where this will be required, so I'll be able to give it a good spin soon enough (on L10).

[kirkbushell]

Quoting from #311
where the changes tested and could it cause issues with older versions of Laravel Framework?

I've not tested it as I need it to support Laravel 10 before I'm able to consider integrating this into my project.

However, as I mentioned, the original condition compares against two classes AlternativePart and MixedPart both of which inherit from AbstractMultipartPart so there's no reason why it wouldn't work.

The existing test suite is comfortable with the change and the functionality continues regardless of it.

That being said, I know often this assurance isn't enough to warrant merging, since it could break compatibility. At the moment, I only have a Laravel 10 project in which to test this, so I can't verify it won't break previous versions, I'd appreciate it if someone could help test this in a previous laravel version.

I'm not certain this solves the underlying problem, since I was just actioning the suggestion made in #311 but I'm nearly at the point in my project where this will be required, so I'll be able to give it a good spin soon enough (on L10).

It's not a laravel 10 issue, as I got it working on Laravel 10. My problem was that the assets weren't built and therefore were not visible to css-inliner, as I am using vite.

[DannyvdSluijs]

Successfully tested the changes using the following matrix:

• Laravel 10 with Content-Type: text/html; charset=utf-8
• Laravel 10 with Content-Type: multipart/related;
• Laravel 9 with Content-Type: text/html; charset=utf-8
• Laravel 9 with Content-Type: multipart/related;