Allow systemd-fstab-generator read all symlinks #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zpytela
commented
Oct 19, 2023
zpytela
commented
The fstab generator uses the access() syscall to /sys with W_OK to check if the system is running in a container, but the directory has the 0555 mode so the DAC_OVERRIDE capability is required. Resolves: rhbz#2244994
The fstab-generator canonicalizes paths before creating a mount unit, so it needs to be able to read all symlinks. This is required in ostree systems which have /home as a symlink to /var/home. Resolves: rhbz#2244878
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.