Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-10449: Delete Objects MD5 Python3.9 Fix #2521

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

dpb-bah
Copy link
Contributor

@dpb-bah dpb-bah commented Dec 8, 2023

High level description:
After upgrading to Python3.9, the Delete Submission feature was not functional with an error message of

An error occurred (InvalidRequest) when calling the DeleteObjects operation: Missing required header for this request: Content-MD5 OR x-amz-checksum-*

Technical details:
In Python3.9, the hash library for generating MD5s on FIPS systems was updated to not generate hashs for FIPS systems. This MD5 is crucial for interacting with AWS, specifically requiring an MD5 header when deleting objects from S3 buckets. The hash library does include an additional keyword argument (usedforsecurity, defaulted to True) to bypass the security check that hasn't been updated in the botocore library. The solution involves making a forked version of botocore that uses the new flag (setting it to False) to bypass it and running off that.

See boto/botocore#2769 (comment)

Link to JIRA Ticket:
DEV-10449

The following are ALL required for the PR to be merged:

  • Backend review completed
  • Style Guide check completed
  • Unit & integration tests updated with relevant test cases
  • Frontend impact assessment completed
  • Documentation updated

@dpb-bah dpb-bah added the hotfix PR directly into master for production fix label Dec 8, 2023
alburde1
alburde1 previously approved these changes Dec 11, 2023
@dpb-bah dpb-bah merged commit 3e76136 into staging Dec 13, 2023
1 check passed
@dpb-bah dpb-bah deleted the fix/dev-10449-botocore-md5-fix branch December 13, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix PR directly into master for production fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants