Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing jQuery UI Dialog #311

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Replacing jQuery UI Dialog #311

merged 2 commits into from
Feb 27, 2024

Conversation

paul90
Copy link
Member

@paul90 paul90 commented Feb 8, 2024

Replacing jQuery UI dialog with a child 'popup' window. By changing dialog.coffee this replaces all jQuery UI based dialogs at once.

On some browsers and devices the child window might open in a tab, or if the user has the opening of child windows blocked be requested to unblock for the wiki site. But, it removes the dialog that obscures a portion of the screen, and may present a challenge in a small windows.

Replacing Screenshot 2024-02-08 at 10 38 12

with Screenshot 2024-02-08 at 10 41 03

just a straight replacement with a popup window
@paul90 paul90 merged commit 321199f into master Feb 27, 2024
2 checks passed
@paul90 paul90 deleted the paul90/dialog branch February 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants